Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance & General Housekeeping #1206

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Performance & General Housekeeping #1206

wants to merge 5 commits into from

Conversation

JustArion
Copy link
Contributor

  • Moves reused Guids to the static scope (Other files do this already)
  • Removes some redundant type casts in NAudio.Wasapi
  • Removes redundant backing field usages in NAudio.Wasapi

Feel free to cherry pick commits ;)
I would like to ask for some clarification on code style. Perhaps add a .editorconfig for future contributors. There's a lot of instances where var is used on simple types but then full type names are used in other places eg. int

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JustArion