Skip to content

Conversation

@faysou
Copy link
Collaborator

@faysou faysou commented Jan 5, 2026

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

  • In order to have parity with what is used for TestClock and have some control over which timer is executed first if they fire at the same time. This can be useful for example to ensure that a spread aggregator fires before a bar aggregator, based on timer names.

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Improvement (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@cjdsellers
Copy link
Member

Thanks @faysou

This is a good refinement and improves parity between the clock types 🙏

@cjdsellers cjdsellers merged commit 16f8d6d into develop Jan 5, 2026
19 checks passed
@cjdsellers cjdsellers deleted the live-timers branch January 5, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants