Skip to content

Refine handling of skip_first_non_full_bar in TimeBarAggregator #3395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cjdsellers merged 1 commit into from
Jan 6, 2026
Merged

Refine handling of skip_first_non_full_bar in TimeBarAggregator #3395

cjdsellers merged 1 commit into from
Jan 6, 2026
+66 −44

Conversation

@faysou
Copy link
Collaborator

@faysou faysou commented Jan 6, 2026 •
edited
Loading

Pull Request

NautilusTrader prioritizes correctness and reliability, please follow existing patterns for validation and testing.

  • I have reviewed the CONTRIBUTING.md and followed the established practices

Summary

  • Refine handling of skip_first_non_full_bar in TimeBarAggregator
  • Fixes edge case where start time of aggregator coincides with a close time. We allow bars after the close time.

Related Issues/PRs

Type of change

  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Improvement (non-breaking)
  • Breaking change (impacts existing behavior)
  • Documentation update
  • Maintenance / chore

Breaking change details (if applicable)

Documentation

  • Documentation changes follow the style guide (docs/developer_guide/docs.md)

Release notes

  • I added a concise entry to RELEASES.md that follows the existing conventions (when applicable)

Testing

Ensure new or changed logic is covered by tests.

  • Affected code paths are already covered by the test suite
  • I added/updated tests to cover new or changed logic

@faysou faysou changed the title bar-fix Refactor start_timer in TimeBarAggregator Jan 6, 2026
@faysou faysou marked this pull request as draft January 6, 2026 12:33
@faysou faysou marked this pull request as ready for review January 6, 2026 15:45
@faysou faysou changed the title Refactor start_timer in TimeBarAggregator Refine handling of skip_first_non_full_bar in TimeBarAggregator Jan 6, 2026
@cjdsellers
Copy link
Member

cjdsellers commented Jan 6, 2026

Thanks @faysou

@cjdsellers cjdsellers merged commit 5ff29cb into develop Jan 6, 2026
19 checks passed
@cjdsellers cjdsellers deleted the bar-fix branch January 6, 2026 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@faysou @cjdsellers