feat(types): add datetime.date and datetime.datetime support for Tag values (ITL-45) by kurodo3[bot] · Pull Request #188 · nauticalab/orcapod-python

kurodo3 · 2026-06-29T01:22:22Z

Summary

Bumps starfix to ~=0.4.0, which adds pa.timestamp hashing support — enabling content_hash() on Tags with datetime columns
Adds datetime.date ↔ pa.date32() bidirectional mapping in UniversalTypeConverter (fixes arrow_type_to_python_type(pa.date32()) returning Any)
Adds date and datetime to the TagValue and SupportedNativePythonData public type aliases (removes the TODO comment)
Adds 11 integration tests in TestTagDatetimeValues covering construction, round-trip, Arrow schema, content hashing, naive-datetime rejection, and schema inference for both types

Test plan

uv run pytest test-objective/unit/test_semantic_types.py -k "date" -v — 3 new type-converter tests pass
uv run pytest test-objective/unit/test_tag.py::TestTagDatetimeValues -v — all 11 integration tests pass
uv run pytest test-objective/ tests/ -q — full suite: 4341 passed, 56 skipped, 13 xfailed

Closes ITL-45

🤖 Generated with Claude Code

…443, ITL-444)

starfix 0.4.0 adds support for hashing pa.timestamp Arrow types, which is required for content_hash() to work on Tags containing datetime values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…peConverter

…honData

codecov · 2026-06-29T01:23:34Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Copilot

Pull request overview

This PR formalizes datetime.date and datetime.datetime as supported Tag value types by aligning public type aliases with the Arrow conversion layer, and by upgrading starfix so content_hash() can hash Arrow timestamp columns.

Changes:

Bump starfix to ~=0.4.0 to enable hashing for pa.timestamp(...) columns used by datetime-valued Tags.
Extend UniversalTypeConverter with an explicit date ↔ pa.date32() mapping (and reverse mapping via pa.types.is_date).
Update public type aliases (TagValue, SupportedNativePythonData) and add integration/unit tests covering construction, round-trip, schema inference, and hashing for date/datetime Tag values.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`pyproject.toml`	Bumps `starfix` to `~=0.4.0` to support timestamp hashing.
`uv.lock`	Locks the resolved `starfix==0.4.0` artifact metadata.
`src/orcapod/semantic_types/universal_converter.py`	Adds direct `date → pa.date32()` mapping and `pa.date* → date` reverse mapping.
`src/orcapod/types.py`	Expands public type aliases to include `date` and `datetime`.
`test-objective/unit/test_semantic_types.py`	Adds converter tests for `date` type mapping and schema round-trip.
`test-objective/unit/test_tag.py`	Adds `TestTagDatetimeValues` integration tests for Tag behavior with date/datetime values.
`superpowers/specs/2026-06-29-itl-45-datetime-tag-values-design.md`	Adds design doc describing goals, scope, and the chosen Arrow mappings.
`superpowers/plans/2026-06-29-itl-45-datetime-tag-values.md`	Adds an implementation plan for the change set and verification steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kurodo3 · 2026-06-29T01:35:49Z

+        ctx = _make_context()
+        tag = Tag({"dob": date(2024, 1, 15)}, data_context=ctx)
+        table = tag.as_table()
+        assert pa.types.is_date(table.schema.field("dob").type)


Good catch. Changed the assertion to assert table.schema.field("dob").type == pa.date32() — this pins the exact type and will catch any silent regression to date64.

kurodo3 · 2026-06-29T01:35:56Z

+        dt = datetime(2024, 1, 15, 12, 0, 0, tzinfo=timezone.utc)
+        tag = Tag({"ts": dt}, data_context=ctx)
+        table = tag.as_table()
+        assert pa.types.is_timestamp(table.schema.field("ts").type)


Good catch. Changed to assert table.schema.field("ts").type == pa.timestamp("us", tz="UTC") — this pins both the microsecond precision and the UTC timezone, fully encoding the converter contract.

- Assert exact `pa.date32()` type in `test_date_tag_as_table_schema` instead of the weaker `pa.types.is_date()` predicate, preventing silent regressions to date64 - Assert exact `pa.timestamp("us", tz="UTC")` type in `test_datetime_tag_as_table_schema` instead of `pa.types.is_timestamp()`, pinning both the unit and timezone as required by the converter contract - Fix typo "accomodate" → "accommodate" in the spec and plan docs Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

kurodo3 · 2026-06-29T01:36:13Z

Review round addressed (commit `0f3e2edc`)

Four comments fixed in a single commit:

Comment	Fix
`test_date_tag_as_table_schema` used `pa.types.is_date()` — too broad	Changed to `== pa.date32()` — pins exact type, prevents silent regression to `date64`
`test_datetime_tag_as_table_schema` used `pa.types.is_timestamp()` — too broad	Changed to `== pa.timestamp("us", tz="UTC")` — pins both precision and timezone per the converter contract
Typo "accomodate" in spec doc	Fixed → "accommodate"
Typo "accomodate" in plan doc	Fixed → "accommodate"

All 11 TestTagDatetimeValues tests continue to pass.

Copilot

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

kurodo3 · 2026-06-29T01:55:55Z

Review round (no code changes)

The single comment in this round was declined:

Comment	Decision	Reason
Remove unused `timezone` import	❌ Declined	`timezone` is used in 5 places — every `datetime`-valued test constructs `datetime(..., tzinfo=timezone.utc)` (lines 196, 202, 210, 217, 239). Removing it would cause `NameError` in those tests.

No changes pushed.

kurodo3 Bot and others added 8 commits June 29, 2026 00:43

docs(specs): add ITL-45 datetime/date tag values design spec

3c3ae4a

docs(specs): update ITL-45 spec with follow-up issue references (ITL-…

fe36481

…443, ITL-444)

docs(plans): add ITL-45 datetime/date tag values implementation plan

b3da4d4

chore(deps): bump starfix to ~=0.4.0 for datetime hashing support

1b436dd

starfix 0.4.0 adds support for hashing pa.timestamp Arrow types, which is required for content_hash() to work on Tags containing datetime values. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

test(types): add failing tests for date <-> date32 type conversion

0c91271

feat(types): add datetime.date <-> pa.date32() support in UniversalTy…

a178832

…peConverter

feat(types): add date and datetime to TagValue and SupportedNativePyt…

90f26e9

…honData

test(tag): add date and datetime tag value tests

7b4b673

eywalker requested a review from Copilot June 29, 2026 01:24

Copilot started reviewing on behalf of eywalker June 29, 2026 01:25 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

eywalker requested a review from Copilot June 29, 2026 01:52

Copilot started reviewing on behalf of eywalker June 29, 2026 01:52 View session

Copilot AI reviewed Jun 29, 2026

View reviewed changes

Comment thread test-objective/unit/test_semantic_types.py

eywalker approved these changes Jun 29, 2026

View reviewed changes

eywalker merged commit 4fbb856 into main Jun 29, 2026
12 checks passed

eywalker deleted the eywalker/itl-45-add-support-for-datetime-in-tag-values branch June 29, 2026 03:39

Navigation Menu

Uh oh!

feat(types): add datetime.date and datetime.datetime support for Tag values (ITL-45) - #188

feat(types): add datetime.date and datetime.datetime support for Tag values (ITL-45)#188
eywalker merged 9 commits into
mainfrom
eywalker/itl-45-add-support-for-datetime-in-tag-values

kurodo3 Bot commented Jun 29, 2026

Uh oh!

codecov Bot commented Jun 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

kurodo3 Bot Jun 29, 2026

Uh oh!

kurodo3 Bot Jun 29, 2026

Uh oh!

Uh oh!

Uh oh!

kurodo3 Bot commented Jun 29, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

kurodo3 Bot commented Jun 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

kurodo3 Bot commented Jun 29, 2026

Summary

Test plan

Uh oh!

codecov Bot commented Jun 29, 2026

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

kurodo3 Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

kurodo3 Bot Jun 29, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kurodo3 Bot commented Jun 29, 2026

Review round addressed (commit 0f3e2edc)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

kurodo3 Bot commented Jun 29, 2026

Review round (no code changes)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Review round addressed (commit `0f3e2edc`)