-
Notifications
You must be signed in to change notification settings - Fork 6
Add output_packet to PodResult
#104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…ork namespace for some error tests.
…and add note about reusing cache when running tests with coverage i.e. build faster.
|
I spent some more time on this since it came up elsewhere. Turns out that the clippy suggestion is actually a good one and it is about understanding how memory is allocated to the stack for enums. Basically, by using box for external errors, we cap out the memory per variant to a pointer to the heap which is just 8 bytes which overall should reduce the memory of our
I was doing some more thinking on this and there is a distinction we should make that we can use Static being the data that doesn't change for the life of the pipeline run (e.g. Dynamic being the data that changes while it is progressing (e.g. node states, terminated time, packets completed per node, etc.). This is where we can do something similar to the orchestrator (perhaps In summary, |
…re flexible, remove print to console from agent client log, and simplify store regex.
Synicix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Feature
Housekeeping
Packet.Status->PodStatusto give a clear distinction once we introducePipelineStatus.RunInfo->PodRunInfoto give a clear distinction once we introducePipelineRunInfo.OrcaError.EventMetadataand removeevent_classifierfromstart_service(..).log(..).Docs
Tests