Skip to content

Conversation

@guzman-raphael
Copy link
Contributor

@guzman-raphael guzman-raphael commented Aug 10, 2025

Features

  • Localize zenoh key expression structure to a single builder for both pub/sub (see make_key_expr). Keys are alphabetically sorted in key expression.
  • Relax structure to be mostly self-describing. This means that the builder structure is minimal and the caller is free to add as much context as necessary via metadata.
  • When in sub mode, key are delimited by wildcards to allow room to grow. The result is a key expression parsing logic that will be backward compatible with future releases provided we primarily add new keys in the future. Renames will present backward incompatibility but that is somewhat expected. Therefore to avoid this, we should try to pick good key names that we don't expect to rename in the future.
  • Eliminate the need to maintain an agent regex and the capture struct i.e. EventMetadata.

Tests

  • Add a default and a test feature. It is only allowed to enable one of them at a time.
    • Default (which is the default feature) will not expose any part of the private API in core.
    • Test will expose some portion of core. This is useful when integration tests need access to core.

Docs

  • Add note about using git worktree

Housekeeping

  • Simplify errors related to None values to a single MissingInfo error. The details field can be used to elaborate on what is missing and provide a hint to API user.
  • Clean up some of the while loops that silenced certain error states.

…pub/sub (make_key_expr), relax structure to be mostly self-describing, and eliminate the need for agent regex + capture struct.
@guzman-raphael guzman-raphael changed the title Relax zenoh key expression structure Make zenoh key expression structure easier to maintain Aug 10, 2025
…ence certain errors, parse datetime in provided event metadata to agent services, and add docs on git worktrees.
@guzman-raphael guzman-raphael marked this pull request as ready for review August 11, 2025 01:56
@guzman-raphael guzman-raphael requested a review from Synicix August 11, 2025 02:08
Copy link
Contributor

@Synicix Synicix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge to have a base to work off of

@Synicix Synicix merged commit 5abc2ca into nauticalab:dev Aug 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants