Skip to content

Conversation

@Synicix
Copy link
Contributor

@Synicix Synicix commented Oct 22, 2025

Out of interest of reducing the amount of searching for blocks of code that was split between Core and Uniffi, after much discussion we decided to merge them into 1 file to simplify the developing experience and code base.

  • Combined Uniffi and Core together
  • Convert a few function back to private since it didn't need to be expose
  • Move some integration tests to unit tests
  • Review all clippy exception and remove a few disable flags to enable better coding practices

fixes PLT-274

@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 95.98420% with 61 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/model/pipeline.rs 97.16% 24 Missing ⚠️
src/error.rs 85.96% 16 Missing ⚠️
src/store/filestore.rs 95.32% 8 Missing ⚠️
src/orchestrator/docker.rs 90.66% 7 Missing ⚠️
src/orchestrator/agent.rs 96.59% 5 Missing ⚠️
src/model/mod.rs 66.66% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@eywalker eywalker merged commit 358e397 into nauticalab:dev Oct 22, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants