-
Notifications
You must be signed in to change notification settings - Fork 6
MVP Pipeline Implementation with Utils update #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
8e1b2f3
Cut out a features to deffer till later. MVP implementation needed fo…
Synicix e2705c7
Rename error to be more clear
Synicix 770ac57
Added uniffi bindings
Synicix e3929b3
Fix OOM issue with stress test
Synicix 0c557c2
Adjust tolerance for pi
Synicix 075543c
Merge branch 'dev' of github.com:walkerlab/orcapod into Synicix/pipeline
guzman-raphael 76b4a95
Apply review feedback.
guzman-raphael eacd2cf
Remove unneeded PartialEq trait implementation.
guzman-raphael dfdee37
Add pipeline job test that validates input checksums, extract pod_cus…
guzman-raphael 8eb6c34
Cover container dead case in docker orchestrator.
guzman-raphael 70631ef
Debug GHA.
guzman-raphael abe0a7e
Add dot error test.
guzman-raphael 18873c6
Add packet validation.
guzman-raphael ea40e21
Fix bug in packet validation.
guzman-raphael a0102b4
Set project coverage check to 95%.
guzman-raphael d57484c
Add test for incomplete packet.
guzman-raphael c5e7285
Allow dashes in agent group, logically isolate agent communication in…
guzman-raphael c2c77c9
Merge remote-tracking branch 'upstream/dev' into pipeline
Synicix 832ff47
Merge branch 'dev' into pipeline
Synicix 8d9a633
Merge branch 'pipeline' of github.com:Synicix/orcapod into Synicix/pi…
guzman-raphael 674dea1
Split model module in uniffi to make it easier to maintain.
guzman-raphael 5ad6e67
Merge pull request #7 from guzman-raphael/Synicix/pipeline
Synicix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Allocating a
Stringinline for the label key is unnecessary. Consider defining aconst POD_JOB_LABEL: &str = "org.orcapod.pod_job"and using&POD_JOB_LABEL.to_owned()or similar to avoid repeatedto_owned()calls.