Skip to content

Convert Cisco status to bool correctly#462

Open
icovada wants to merge 7 commits intodevelopfrom
461-no-shut-interfaces-on-cisco-might-appear-ad-not-enabled
Open

Convert Cisco status to bool correctly#462
icovada wants to merge 7 commits intodevelopfrom
461-no-shut-interfaces-on-cisco-might-appear-ad-not-enabled

Conversation

@icovada
Copy link
Copy Markdown

@icovada icovada commented Dec 2, 2025

Closes: #461

What's Changed

Added a cisco-specific jinja filter to map interface status to Interface "Enabled" field

output Before After
administratively down Not Enabled Not Enabled
down Not Enabled Enabled
up Enabled Enabled

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@mattmiller87
Copy link
Copy Markdown

Not sure why ruff is failing. Linter in GHA isn't telling and locally I get:

ruff check nautobot_device_onboarding/jinja_filters.py 
All checks passed!

@jeffkala
Copy link
Copy Markdown
Contributor

We need to figure out our stance on public filters the app offers. Because this in theory could be a breaking change for anyone writing their own parsers using these filters we expose.

@smk4664
Copy link
Copy Markdown
Contributor

smk4664 commented Dec 15, 2025

We need to figure out our stance on public filters the app offers. Because this in theory could be a breaking change for anyone writing their own parsers using these filters we expose.

This is a new filter, so it is not a breaking change in that respect.


def test_cisco_interface_status_to_bool_linkup(self):
"""Take links or admin status and change to boolean."""
self.assertFalse(cisco_interface_status_to_bool("up"))
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this test assert True if the interface is link up?

Also, would it be possible to apply the new filter to the XR command mapper?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"no shut" interfaces on Cisco might appear ad not enabled

5 participants