Skip to content

Updated_Device_onboarding_images#472

Merged
itdependsnetworks merged 9 commits intodevelopfrom
u/sudheer-Device-onboarding
Feb 16, 2026
Merged

Updated_Device_onboarding_images#472
itdependsnetworks merged 9 commits intodevelopfrom
u/sudheer-Device-onboarding

Conversation

@sudheervarma-network
Copy link
Copy Markdown
Contributor

@sudheervarma-network sudheervarma-network commented Dec 26, 2025

@sudheervarma-network sudheervarma-network marked this pull request as draft December 26, 2025 10:07
@sudheervarma-network sudheervarma-network self-assigned this Dec 26, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 26, 2025

Coverage report

This PR does not seem to contain any modification to coverable code.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. The images seem distorted. In google sheets you should not expand left/right or north/south, but instead should only expand from the corners, this ensures that the ratio of the image stays the same
  2. Copy the numbers of the circles from the example sheet, as the font looks different here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as requested, should be resolve, let me know if I missed anything.

Comment thread docs/user/app_getting_started.md Outdated
You can check out the [Use Cases](app_use_cases.md) section for more examples or try out the job inputs with at least the required fields.

![job input](../images/sync_devices_inputs.png)
![job input](../images/s-sync_device_inputs_light.png#only-light){ .on-glb }
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create two images here and note the differences between them. e.g.

Manual Input:

<put image 1 of manual input here>

CSV Input:

<put image 2 of csv input here>

@itdependsnetworks
Copy link
Copy Markdown
Contributor

Remove the prefix s- from all images

@itdependsnetworks itdependsnetworks marked this pull request as ready for review January 13, 2026 13:48
Comment thread docs/user/app_getting_started.md
Copy link
Copy Markdown
Contributor

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@itdependsnetworks itdependsnetworks merged commit 5818f88 into develop Feb 16, 2026
15 checks passed
@itdependsnetworks itdependsnetworks deleted the u/sudheer-Device-onboarding branch February 16, 2026 13:56
@cdtomkins cdtomkins mentioned this pull request Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants