Fix bug when syncing interfaces installed in a module#476
Merged
gsnider2195 merged 5 commits intodevelopfrom Jan 9, 2026
Merged
Fix bug when syncing interfaces installed in a module#476gsnider2195 merged 5 commits intodevelopfrom
gsnider2195 merged 5 commits intodevelopfrom
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
smk4664
approved these changes
Jan 9, 2026
Contributor
smk4664
left a comment
There was a problem hiding this comment.
This looks great! I see some improvements in here that should lower the repetitive database hits by using data we already received from a previous query instead of doing a new filter.
jeffkala
approved these changes
Jan 9, 2026
Contributor
jeffkala
left a comment
There was a problem hiding this comment.
looks good to me. As long as all the testing is still working I'm satisfied.
Dav-C
approved these changes
Jan 9, 2026
gsnider2195
added a commit
that referenced
this pull request
Jan 12, 2026
…talled in a module (#476)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: NAPPS-799
Bug
When onboarding a Device that uses a DeviceType with InterfaceTemplates attached to ModuleTypes, the Device will be created with interfaces that have a null
devicefield. On subsequentSync Network Datajobs, the job will try to recreate the interface attached directly to the device instead of attached to the module.What's Changed
What this PR does: This PR makes the diffsync Nautobot adapters aware of existing interfaces connected to devices through modules (
Interface.deviceis null butInterface.moduleis not null).What this PR does not do: Change any of the diffsync Network adapters to parse module information or onboard Device Modules.
To Do