FIX #277

[pato23arg]

Closes: #277

What's Changed

• Closes Git Overrides don't work with multiple provides in the same datasource #277
• Refactors get_git_repo to use .get() for better error handling.
• Adds tests for GetGitRepo.

To Do

• Explanation of Change(s)
• Added change log fragment(s) (for more information see the documentation)
• Attached Screenshots, Payload Example
• Unit, Integration Tests
• Documentation Updates (when adding/changing features)
• Outline Remaining Work, Constraints from Design

[jeffkala]

I'm not sure this is actually the right fix... Most other datasources support multiple repos providing the same thing. Need to get clear understanding and make sure its following the proper POLA.

[pato23arg]

I'm not sure this is actually the right fix... Most other datasources support multiple repos providing the same thing. Need to get clear understanding and make sure its following the proper POLA.

have multiple repos been actively requested as a feature? what user story would it address?

[jeffkala]

I'm not sure this is actually the right fix... Most other datasources support multiple repos providing the same thing. Need to get clear understanding and make sure its following the proper POLA.

have multiple repos been actively requested as a feature? what user story would it address?

Not that I'm aware of, just saying we support it nearly everywhere else.

• can have multiple repos doing config context
• can have multiple repos doing GC backups
• etc.

I think for the current issue I'm good with your fix, just saying we should at least put multiple repo support in an feature request to track if people want it.

[jeffkala]

any unittest we can add to test this?

[pato23arg]

I'm not sure this is actually the right fix... Most other datasources support multiple repos providing the same thing. Need to get clear understanding and make sure its following the proper POLA.

have multiple repos been actively requested as a feature? what user story would it address?

Not that I'm aware of, just saying we support it nearly everywhere else.

* can have multiple repos doing config context

* can have multiple repos doing GC backups

* etc.

I think for the current issue I'm good with your fix, just saying we should at least put multiple repo support in an feature request to track if people want it.

makes sense, would it make sense to wait for FR or put one out there to see if it gains traction?

[pato23arg]

any unittest we can add to test this?

absolutely, I can do that.

[jeffkala]

I'm not sure this is actually the right fix... Most other datasources support multiple repos providing the same thing. Need to get clear understanding and make sure its following the proper POLA.

have multiple repos been actively requested as a feature? what user story would it address?

Not that I'm aware of, just saying we support it nearly everywhere else.

* can have multiple repos doing config context

* can have multiple repos doing GC backups

* etc.

I think for the current issue I'm good with your fix, just saying we should at least put multiple repo support in an feature request to track if people want it.

makes sense, would it make sense to wait for FR or put one out there to see if it gains traction?

Please put in an FR in the repo and we will use that to track

[pato23arg]

any unittest we can add to test this?

absolutely, I can do that.

tests IN.

[cdtomkins]

Also please fix To Do, improve description and fix up the checks that are failing. The code improvement itself looks good, thanks!

[pato23arg]

Also please fix To Do, improve description and fix up the checks that are failing. The code improvement itself looks good, thanks!

I think formatter tests are broken for nautobot3.0. You prob don't see that in develop as I see these tests are skipped.

[cdtomkins]

Could you please import the latest tests from develop into your branch to match the skipped tests?