Skip to content

Conversation

@Defiantearth
Copy link
Contributor

Closes: #319

This PR builds on the original work from @johannwagner. Since the original PR was inactive, we created a new branch incorporating their changes and added the final updates needed to complete the fix.
You can find the original pull request here.

What's Changed

Fixed an incompatibility when slugifying capirca names that start with a number by prefixing the name with an underscore.

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  nautobot_firewall_models/utils
  capirca.py
Project Total  

This report was generated by python-coverage-comment-action

@Defiantearth Defiantearth force-pushed the u/defiantearth/fix-319/johannwagner-changes branch from 4854b94 to 48e4d16 Compare November 20, 2025 15:47
Copy link
Contributor

@gsnider2195 gsnider2195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Defiantearth Defiantearth changed the title fix: Prefix names starting with numbers with an underscore fix: Prefix names starting with numbers with an underscore in slugify function Nov 21, 2025
@Defiantearth Defiantearth merged commit db051a0 into develop Nov 21, 2025
13 checks passed
@Defiantearth Defiantearth deleted the u/defiantearth/fix-319/johannwagner-changes branch November 21, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capirca configuration generation will crash if address object starts with a number

4 participants