Skip to content

Conversation

@Defiantearth
Copy link
Contributor

@Defiantearth Defiantearth commented Nov 26, 2025

Closes: NAPPS-724

What's Changed

  • Restored missing action buttons on PolicyRule and NATPolicyRule tables.
  • Replaced the UserObject queryset filter with one that correctly filters on the name and username fields, fixing an issue where the previous base filter incorrectly expected a description field that this model does not have.

Before

Screenshot 2025-11-26 at 11 50 12 AM

After

Screenshot 2025-11-26 at 12 23 48 PM

Before

Screenshot 2025-11-26 at 11 52 39 AM

After

Screenshot 2025-11-26 at 11 52 53 AM

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@github-actions
Copy link

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  nautobot_firewall_models
  filters.py
Project Total  

This report was generated by python-coverage-comment-action

@yanshcodilime
Copy link
Contributor

Looks good, thanks!

@yanshcodilime yanshcodilime merged commit 96b2b2f into develop Nov 27, 2025
13 checks passed
@yanshcodilime yanshcodilime deleted the u/defiantearth/NAPPS-724/3.0-QA-review-fixes branch November 27, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants