Skip to content

Added try/except in sync_complete of vSphere Integration #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
qduk wants to merge 3 commits into
base: develop
Choose a base branch
from
+8 −1
Open

Added try/except in sync_complete of vSphere Integration #1177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28365a1
Added try/except in sync_complete
qduk Apr 6, 2026
9ac4c1e
Added Changelog fragment
qduk Apr 6, 2026
5d6359f
Linted
qduk Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changes/1176.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed vSphere nautobot adapter sync_complete to handle missing VirtualMachine gracefully instead of raising DoesNotExist exception.
8 changes: 7 additions & 1 deletion nautobot_ssot/integrations/vsphere/diffsync/adapters/adapter_nautobot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,13 @@
def sync_complete(self, source, diff, flags: DiffSyncFlags = DiffSyncFlags.NONE, logger=None):
"""Update devices with their primary IPs once the sync is complete."""
for info in self._primary_ips:
vm = VirtualMachine.objects.get(**info["device"])
try:
vm = VirtualMachine.objects.get(**info["device"])
Copy link
Copy Markdown
Contributor

@jdrew82 jdrew82 Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we get test coverage on this?

except VirtualMachine.DoesNotExist:
self.job.logger.warning(
f"VirtualMachine not found for {info['device']}, skipping primary IP assignment."
)
continue

Check warning on line 56 in nautobot_ssot/integrations/vsphere/diffsync/adapters/adapter_nautobot.py

View workflow job for this annotation

GitHub Actions / unittest_report (3.13, postgresql, stable)

Missing coverage 

Missing coverage on lines 52-56
for ip in ["primary_ip4", "primary_ip6"]:
if info[ip]:
setattr(vm, ip, IPAddress.objects.get(host=info[ip]))
Expand Down
Loading