Skip to content

update warning#1184

Merged
jdrew82 merged 3 commits intodevelopfrom
u/defiantearth/defer-warning-message
Apr 10, 2026
Merged

update warning#1184
jdrew82 merged 3 commits intodevelopfrom
u/defiantearth/defer-warning-message

Conversation

@Defiantearth
Copy link
Copy Markdown
Contributor

@Defiantearth Defiantearth commented Apr 10, 2026

What's Changed

Deferred the missing python-magic warning in pysnow to only emit when attachment upload is attempted, rather than at import time.

To Do

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)

Copy link
Copy Markdown
Contributor

@mattmiller87 mattmiller87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Watched this happen in real time. Approved.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  nautobot_ssot/integrations/servicenow/third_party/pysnow
  attachment.py
Project Total  

This report was generated by python-coverage-comment-action

@jdrew82 jdrew82 added type: bug Issues/PRs addressing a bug. integration: servicenow Issues originally from standalone ServiceNow SSoT repo labels Apr 10, 2026
Copy link
Copy Markdown
Contributor

@jdrew82 jdrew82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdrew82 jdrew82 merged commit 956d58a into develop Apr 10, 2026
16 checks passed
@jdrew82 jdrew82 deleted the u/defiantearth/defer-warning-message branch April 10, 2026 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration: servicenow Issues originally from standalone ServiceNow SSoT repo type: bug Issues/PRs addressing a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants