fix handling of foreign custom fields#759
Open
Phill93 wants to merge 3 commits intonautobot:developfrom
Open
Conversation
Contributor
|
Hey @Phill93 and thanks for the PR! Please
|
Contributor
|
@Phill93 just wanted to see if you could address the requested changes from @Kircheneer? |
Author
|
@jdrew82 Yes, I have that on the plan. I just don't have time for it right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #723
What's Changed
Handle foreign custom fields. The attribute
_custom_field_datacontains a dictionary sogetattrfails with anAttributeErrorexception. My fix checks ifrelated_objectis a dictionary and handles that different.To Do