Remove expired A and PTR records left when HTTP 404 is seen#923
Open
MeganerdDev wants to merge 3 commits intonautobot:developfrom
Open
Remove expired A and PTR records left when HTTP 404 is seen#923MeganerdDev wants to merge 3 commits intonautobot:developfrom
MeganerdDev wants to merge 3 commits intonautobot:developfrom
Conversation
added 2 commits
July 25, 2025 10:41
jdrew82
requested changes
Aug 13, 2025
Contributor
jdrew82
left a comment
There was a problem hiding this comment.
@MeganerdDev can you address the linter and ensure tests are passing and we have coverage for these new bits? Also, I think this should be behind a setting for the integration so that users choose this behavior. We don't want to surprise them if data goes missing unexpectedly.
This was referenced Aug 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #922
What's Changed
We will attempt to remove "stale" records when we see the HTTP 404 for A and PTR records
To Do