feat(w21-24kl): batch 16 — shared ticket helpers + CI test fixes

JoeOakhartNava · claude · JoeOakhartNava · commit 6b2b392c16ea · 2026-03-23T12:37:29.000-07:00
Add ticket_read_status() and ticket_find_open_children() to ticket-lib.sh
for CLI-native health guards (dso-sroj). Add --parent flag parsing to
ticket-create.sh. Fix 10 test files with path migration from old ticket
storage to v3, resolve CLAUDE_PLUGIN_ROOT unbound variable errors, fix
ShellCheck violations, and add RED .test-index markers for pending guard
implementation tests.

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/.test-index b/.test-index
@@ -38,6 +38,9 @@ plugins/dso/scripts/ticket-lib.sh:tests/scripts/test_revert_event.py,tests/scrip
 plugins/dso/scripts/ticket-list.sh:tests/scripts/test-ticket-list.sh,tests/scripts/test_bridge_alert_display.py
 plugins/dso/scripts/ticket-revert.sh:tests/scripts/test_revert_event.py
 plugins/dso/scripts/ticket-show.sh:tests/scripts/test-ticket-show.sh,tests/scripts/test_bridge_alert_display.py
+plugins/dso/scripts/ticket-create.sh:tests/scripts/test-ticket-create.sh [test_create_with_closed_parent_blocked]
+plugins/dso/scripts/ticket-link.sh:tests/scripts/test-ticket-link.sh [test_link_depends_on_closed_target_blocked]
+plugins/dso/scripts/ticket-transition.sh:tests/scripts/test-ticket-transition.sh [test_transition_bug_close_requires_reason]
 plugins/dso/scripts/validate-phase.sh:tests/test-validate-phase-portability.sh
 plugins/dso/scripts/validate.sh:tests/plugin/test-validate-work-portability.sh,tests/hooks/test-validate-review-output.sh,tests/hooks/test-validate-crash-detection.sh,tests/scripts/test-validate-test-batched-integration.sh,tests/scripts/test-validate-flock-timeout.sh,tests/scripts/test-validate-background.sh,tests/scripts/test-validate-skip-ci-flag.sh,tests/scripts/test-validate-issues.sh,tests/scripts/test-validate-config.sh,tests/scripts/test-validate-script-writes-integration.sh,tests/scripts/test-validate-config-driven.sh,tests/scripts/test-validate-state-lifecycle.sh,tests/test-validate-phase-portability.sh
 plugins/dso/scripts/worktree-cleanup.sh:tests/scripts/test_worktree_cleanup_startup_config.py
diff --git a/.tickets/.index.json b/.tickets/.index.json
@@ -42,6 +42,13 @@
     "title": "As a developer, Jira bridge environment variables are configured with guided prompts",
     "type": "story"
   },
+  "dso-1pwb": {
+    "deps": [],
+    "priority": 1,
+    "status": "open",
+    "title": "Fix CI failures from allowlist path migration",
+    "type": "bug"
+  },
   "dso-1s1t": {
     "deps": [
       "dso-ncv2"
diff --git a/.tickets/.sync-state.json b/.tickets/.sync-state.json
@@ -449,8 +449,8 @@
     "last_synced": "2026-03-19T18:38:35Z",
     "local_hash": "14c516947a151a3db8bdec4010e2fd6e"
   },
-  "last_pull_timestamp": "2026-03-23T18:21:21Z",
-  "last_sync_commit": "60ca86de64edef8ef759878b2471445152fe6145",
+  "last_pull_timestamp": "2026-03-23T19:37:02Z",
+  "last_sync_commit": "7366630886dc2984a7fbe149b2d867e78a18668f",
   "w21-5cqr": {
     "jira_hash": "bce29d76f01c58613ee99cb1dd03920d",
     "jira_key": "DIG-61",
diff --git a/.tickets/dso-1pwb.md b/.tickets/dso-1pwb.md
@@ -0,0 +1,12 @@
+---
+id: dso-1pwb
+status: open
+deps: []
+links: []
+created: 2026-03-23T18:32:09Z
+type: bug
+priority: 1
+assignee: Joe Oakhart
+---
+# Fix CI failures from allowlist path migration
+
diff --git a/.tickets/dso-bdk5.md b/.tickets/dso-bdk5.md
@@ -1,6 +1,6 @@
 ---
 id: dso-bdk5
-status: in_progress
+status: closed
 deps: []
 links: []
 created: 2026-03-23T17:34:42Z
diff --git a/.tickets/dso-hu14.md b/.tickets/dso-hu14.md
@@ -1,6 +1,6 @@
 ---
 id: dso-hu14
-status: in_progress
+status: closed
 deps: [dso-1cje, dso-yv90]
 links: []
 created: 2026-03-23T15:20:45Z
diff --git a/.tickets/dso-sroj.md b/.tickets/dso-sroj.md
@@ -1,6 +1,6 @@
 ---
 id: dso-sroj
-status: open
+status: in_progress
 deps: [dso-bdk5]
 links: []
 created: 2026-03-23T17:34:49Z
@@ -25,3 +25,38 @@ Add two shared helper functions to plugins/dso/scripts/ticket-lib.sh:
 
 Both functions follow existing ticket-lib.sh patterns. Use git rev-parse for TRACKER_DIR and BASH_SOURCE for REDUCER path.
 
+## ACCEPTANCE CRITERIA
+
+- [ ] ticket_read_status function exists in ticket-lib.sh
+  Verify: grep -q "ticket_read_status()" plugins/dso/scripts/ticket-lib.sh
+- [ ] ticket_find_open_children function exists in ticket-lib.sh
+  Verify: grep -q "ticket_find_open_children()" plugins/dso/scripts/ticket-lib.sh
+- [ ] ticket-lib.sh passes bash syntax check
+  Verify: bash -n plugins/dso/scripts/ticket-lib.sh
+- [ ] RED tests from dso-bdk5 for helpers now pass (GREEN)
+  Verify: bash tests/scripts/test-ticket-health-guards.sh 2>&1 | grep -qi "passed"
+
+
+**2026-03-23T18:28:02Z**
+
+CHECKPOINT 1/6: Task context loaded ✓
+
+**2026-03-23T18:28:14Z**
+
+CHECKPOINT 2/6: Code patterns understood ✓
+
+**2026-03-23T18:28:15Z**
+
+CHECKPOINT 3/6: Tests written (none required — RED tests exist) ✓
+
+**2026-03-23T18:29:38Z**
+
+CHECKPOINT 4/6: Implementation complete ✓
+
+**2026-03-23T18:29:46Z**
+
+CHECKPOINT 5/6: Validation passed ✓
+
+**2026-03-23T18:29:59Z**
+
+CHECKPOINT 6/6: Done ✓
diff --git a/.tickets/dso-w0fc.md b/.tickets/dso-w0fc.md
@@ -0,0 +1,12 @@
+---
+id: dso-w0fc
+status: open
+deps: []
+links: []
+created: 2026-03-23T18:30:05Z
+type: task
+priority: 3
+assignee: Joe Oakhart
+---
+# ticket-create.sh: update usage docs to reflect --parent flag syntax
+
diff --git a/plugins/dso/docs/workflows/REVIEW-WORKFLOW.md b/plugins/dso/docs/workflows/REVIEW-WORKFLOW.md
@@ -109,8 +109,7 @@ The diff hash is captured here — AFTER Step 1's format/lint/type-check pass 
 
 ```bash
 # Run complexity classifier to determine review tier
-CLASSIFIER="${CLAUDE_PLUGIN_ROOT}/scripts/review-complexity-classifier.sh"
-CLASSIFIER_OUTPUT=$(bash "$CLASSIFIER" < "$DIFF_FILE" 2>/dev/null) || CLASSIFIER_EXIT=$?
+CLASSIFIER_OUTPUT=$(".claude/scripts/dso review-complexity-classifier.sh" < "$DIFF_FILE" 2>/dev/null) || CLASSIFIER_EXIT=$?
 if [[ "${CLASSIFIER_EXIT:-0}" -ne 0 ]] || ! echo "$CLASSIFIER_OUTPUT" | python3 -c 'import json,sys; json.load(sys.stdin)' 2>/dev/null; then
     # Classifier failed — default to standard tier per contract (classifier-tier-output.md)
     REVIEW_TIER="standard"
@@ -144,12 +143,12 @@ DIFF_SIZE_LINES=$(echo "$CLASSIFIER_OUTPUT" | python3 -c 'import json,sys; d=jso
 REVIEW_PASS_NUM="${REVIEW_PASS_NUM:-1}"
 
 # Merge commits bypass size limits entirely (contract: is_merge_commit always checked first)
-# Re-review passes (REVIEW_PASS_NUM >= 2) bypass size limits (re-review exemption rule)
+# re-review passes (REVIEW_PASS_NUM >= 2) bypass size limits (re-review exemption rule)
 if [[ "$IS_MERGE" != "true" ]] && [[ "$REVIEW_PASS_NUM" -le 1 ]]; then
     # Size action branching (initial review, non-merge only)
     if [[ "$SIZE_ACTION" == "upgrade" ]]; then
-        # Upgrade model to opus at current tier's checklist scope
-        REVIEW_AGENT_OVERRIDE="dso:code-reviewer-deep-arch"  # opus model
+        # Upgrade: size_action=upgrade triggers a model_override — use opus reviewer
+        REVIEW_AGENT_OVERRIDE="dso:code-reviewer-deep-arch"  # model_override: opus
         echo "SIZE_UPGRADE: diff has ${DIFF_SIZE_LINES} scorable lines — upgrading to opus reviewer at ${REVIEW_TIER} tier scope"
     fi
 
diff --git a/plugins/dso/scripts/review-complexity-classifier.sh b/plugins/dso/scripts/review-complexity-classifier.sh
@@ -134,7 +134,6 @@ is_critical_path_file() {
     local file="$1"
     case "$file" in
         */db/*|*/database/*|*/auth/*|*/security/*|*/routes/*|*/handlers/*|*/request/*|*/middleware/*|*/persistence/*) return 0 ;;
-        src/auth/*|src/security/*|src/db/*|src/routes/*|src/handlers/*) return 0 ;;
     esac
     return 1
 }
@@ -152,7 +151,7 @@ is_test_file() {
 is_generated_file() {
     local file="$1"
     case "$file" in
-        */migrations/*|*.lock|*package-lock.json|*yarn.lock|*poetry.lock|*.generated.*|*/generated/*) return 0 ;;
+        */migrations/*|*.lock|*package-lock.json|*.generated.*|*/generated/*) return 0 ;;
     esac
     return 1
 }
diff --git a/plugins/dso/scripts/skip-review-check.sh b/plugins/dso/scripts/skip-review-check.sh
@@ -51,7 +51,7 @@ if [[ -f "$_ALLOWLIST_FILE" ]]; then
 else
     # Graceful degradation: fall back to hardcoded patterns when allowlist is missing
     _ALLOWLIST_PATTERNS=(
-        ".tickets/*"
+        ".tickets-tracker/*"
         ".sync-state.json"
         ".checkpoint-needs-review"
         "*.png" "*.jpg" "*.jpeg" "*.gif" "*.svg" "*.ico" "*.webp"
diff --git a/plugins/dso/scripts/ticket-create.sh b/plugins/dso/scripts/ticket-create.sh
@@ -33,7 +33,27 @@ fi
 
 ticket_type="$1"
 title="$2"
-parent_id="${3:-}"
+shift 2
+
+# Parse remaining args: support both positional parent_id and --parent <id>
+parent_id=""
+while [ $# -gt 0 ]; do
+    case "$1" in
+        --parent)
+            parent_id="$2"
+            shift 2
+            ;;
+        --parent=*)
+            parent_id="${1#--parent=}"
+            shift
+            ;;
+        *)
+            # Positional: treat as parent_id (backward-compatible)
+            parent_id="$1"
+            shift
+            ;;
+    esac
+done
 
 # Validate ticket_type
 case "$ticket_type" in
diff --git a/plugins/dso/scripts/ticket-lib.sh b/plugins/dso/scripts/ticket-lib.sh
@@ -212,3 +212,85 @@ sys.exit(0)
 
     return 0
 }
+
+# ticket_read_status <tracker_dir> <ticket_id>
+# Returns the current compiled status of a ticket (e.g., open, in_progress, closed, blocked).
+# Computes REDUCER path internally from BASH_SOURCE — does NOT rely on caller-set globals.
+#
+# Args:
+#   tracker_dir: path to .tickets-tracker worktree (passed by caller)
+#   ticket_id:   ticket directory name (e.g., dso-abc1)
+#
+# Outputs the status string to stdout. Exits non-zero on error.
+ticket_read_status() {
+    local tracker_dir="$1"
+    local ticket_id="$2"
+
+    # Resolve REDUCER path relative to this script's location
+    local lib_dir
+    lib_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+    local reducer="$lib_dir/ticket-reducer.py"
+
+    local ticket_dir="$tracker_dir/$ticket_id"
+
+    if [ ! -d "$ticket_dir" ]; then
+        echo "Error: ticket directory not found: $ticket_dir" >&2
+        return 1
+    fi
+
+    local state_json
+    state_json=$(python3 "$reducer" "$ticket_dir" 2>/dev/null) || {
+        echo "Error: reducer failed for ticket $ticket_id" >&2
+        return 1
+    }
+
+    python3 -c "
+import json, sys
+state = json.loads(sys.argv[1])
+print(state.get('status', ''))
+" "$state_json"
+}
+
+# ticket_find_open_children <tracker_dir> <parent_id>
+# Lists all open (non-closed) child ticket IDs of a given parent ticket.
+# Outputs one ticket ID per line. Exits 0 even if no children are found.
+# Computes REDUCER path internally from BASH_SOURCE — does NOT rely on caller-set globals.
+#
+# Args:
+#   tracker_dir: path to .tickets-tracker worktree (passed by caller)
+#   parent_id:   ticket ID of the parent to search for children of
+ticket_find_open_children() {
+    local tracker_dir="$1"
+    local parent_id="$2"
+
+    # Resolve REDUCER path relative to this script's location
+    local lib_dir
+    lib_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+    local reducer="$lib_dir/ticket-reducer.py"
+
+    if [ ! -d "$tracker_dir" ]; then
+        echo "Error: tracker directory not found: $tracker_dir" >&2
+        return 1
+    fi
+
+    # Scan all subdirectories in tracker_dir, run reducer on each, filter by parent_id
+    local ticket_dir ticket_id state_json
+    for ticket_dir in "$tracker_dir"/*/; do
+        [ -d "$ticket_dir" ] || continue
+        ticket_id="$(basename "$ticket_dir")"
+
+        state_json=$(python3 "$reducer" "$ticket_dir" 2>/dev/null) || continue
+        [ -z "$state_json" ] && continue
+
+        python3 -c "
+import json, sys
+state = json.loads(sys.argv[1])
+parent_id = sys.argv[2]
+ticket_id = sys.argv[3]
+if state.get('parent_id') == parent_id and state.get('status') != 'closed':
+    print(ticket_id)
+" "$state_json" "$parent_id" "$ticket_id"
+    done
+
+    return 0
+}
diff --git a/tests/hooks/test-behavioral-equivalence-allowlist.sh b/tests/hooks/test-behavioral-equivalence-allowlist.sh
@@ -106,10 +106,10 @@ compute_diff_hash_excludes_file() {
 }
 
 # ============================================================
-# Pattern group 1: .tickets/**
+# Pattern group 1: .tickets-tracker/**
 # ============================================================
 test_tickets_non_reviewable_both_consumers() {
-    local file=".tickets/test-ticket.md"
+    local file=".tickets-tracker/test-ticket.md"
 
     local skip_rc=0
     skip_review_classifies_non_reviewable "$file" || skip_rc=$?
diff --git a/tests/hooks/test-compute-diff-hash-tickets.sh b/tests/hooks/test-compute-diff-hash-tickets.sh
@@ -1,6 +1,6 @@
 #!/usr/bin/env bash
 # tests/hooks/test-compute-diff-hash-tickets.sh
-# Tests that .tickets/ and .sync-state.json files are EXCLUDED from compute-diff-hash.sh.
+# Tests that .tickets-tracker/ and .sync-state.json files are EXCLUDED from compute-diff-hash.sh.
 #
 # Ticket metadata changes (checkpoint notes, status updates) must not invalidate
 # code reviews. The diff hash should be stable across ticket-only changes.
@@ -27,7 +27,7 @@ if ! git rev-parse --is-inside-work-tree &>/dev/null; then
 fi
 
 # Work in a temp directory that is a fresh git repo so we don't pollute the
-# real working tree with stray .tickets/ files.
+# real working tree with stray .tickets-tracker/ files.
 TMPDIR_TEST=$(mktemp -d)
 trap 'rm -rf "$TMPDIR_TEST"' EXIT
 
@@ -42,32 +42,32 @@ echo "init" > README.md
 git add README.md
 git commit -q -m "init"
 
-# Create .tickets/ directory and an initial ticket file, then commit it
-mkdir -p .tickets
-echo "status: open" > .tickets/ticket-001.md
-git add .tickets/ticket-001.md
+# Create .tickets-tracker/ directory and an initial ticket file, then commit it
+mkdir -p .tickets-tracker
+echo "status: open" > .tickets-tracker/ticket-001.md
+git add .tickets-tracker/ticket-001.md
 git commit -q -m "add ticket"
 
 # ============================================================
 # test_compute_diff_hash_excludes_tickets_directory
-# Modifying a .tickets/ file should NOT change the hash
+# Modifying a .tickets-tracker/ file should NOT change the hash
 # ============================================================
 echo "--- test_compute_diff_hash_excludes_tickets_directory ---"
 
 HASH_BEFORE=$(bash "$HOOK" 2>/dev/null)
 assert_ne "hash produces non-empty output before" "" "$HASH_BEFORE"
 
 # Modify the ticket file (unstaged change)
-echo "status: closed" >> .tickets/ticket-001.md
+echo "status: closed" >> .tickets-tracker/ticket-001.md
 
 HASH_AFTER=$(bash "$HOOK" 2>/dev/null)
 assert_ne "hash produces non-empty output after" "" "$HASH_AFTER"
 
-# Hashes must be EQUAL — .tickets/ is excluded from the hash
+# Hashes must be EQUAL — .tickets-tracker/ is excluded from the hash
 assert_eq "ticket change does not alter hash" "$HASH_BEFORE" "$HASH_AFTER"
 
 # Reset the ticket change
-git checkout -- .tickets/ticket-001.md
+git checkout -- .tickets-tracker/ticket-001.md
 
 # ============================================================
 # test_compute_diff_hash_excludes_sync_state_json
@@ -104,13 +104,13 @@ assert_eq "compute-diff-hash.sh references review-gate-allowlist" "true" \
 
 # ============================================================
 # test_tickets_exclusion_pathspec_exists
-# The allowlist must contain a .tickets/ pattern (source of truth for pathspec exclusions)
+# The allowlist must contain a .tickets-tracker/ pattern (source of truth for pathspec exclusions)
 # ============================================================
 echo "--- test_tickets_exclusion_pathspec_exists ---"
 
 ALLOWLIST="$DSO_PLUGIN_DIR/hooks/lib/review-gate-allowlist.conf"
-PATHSPEC_MATCH=$(grep '\.tickets/' "$ALLOWLIST" 2>/dev/null | wc -l | tr -d ' ')
-assert_eq "review-gate-allowlist.conf contains .tickets/ pattern" "true" \
+PATHSPEC_MATCH=$(grep '\.tickets-tracker/' "$ALLOWLIST" 2>/dev/null | wc -l | tr -d ' ')
+assert_eq "review-gate-allowlist.conf contains .tickets-tracker/ pattern" "true" \
     "$( [[ $PATHSPEC_MATCH -ge 1 ]] && echo true || echo false )"
 
 # ============================================================
diff --git a/tests/hooks/test-merge-conflict-regression.sh b/tests/hooks/test-merge-conflict-regression.sh
diff --git a/tests/hooks/test-pre-commit-review-gate.sh b/tests/hooks/test-pre-commit-review-gate.sh
diff --git a/tests/hooks/test-pre-commit-test-gate.sh b/tests/hooks/test-pre-commit-test-gate.sh
diff --git a/tests/hooks/test-two-layer-review-gate.sh b/tests/hooks/test-two-layer-review-gate.sh
diff --git a/tests/scripts/test-implementation-plan-contracts.sh b/tests/scripts/test-implementation-plan-contracts.sh
diff --git a/tests/scripts/test-merge-squash-rebase.sh b/tests/scripts/test-merge-squash-rebase.sh
diff --git a/tests/scripts/test-skip-review-check.sh b/tests/scripts/test-skip-review-check.sh
