Staged 2c3b33832330 1780719283

[JoeOakhartNava]

Summary by CodeRabbit

• New Features

  • Added deduplication logic to prevent duplicate local tickets when syncing with existing Jira keys.

• Bug Fixes

  • Improved script compatibility across different operating systems.

• Tests

  • Enhanced test coverage for deduplication functionality and dependency management.

[coderabbitai]

Worried about impact? Review this PR in Change Stack to explore blast radius before you approve or request changes.

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: dc8bc85f-06dd-420a-9671-1358fe87eaf5

📥 Commits

Reviewing files that changed from the base of the PR and between 70e1102 and ca015ac.

📒 Files selected for processing (3)

• plugins/dso/scripts/dso_reconciler/applier.py
• plugins/dso/scripts/dso_reconciler/e2e_field_validation_probe.sh
• tests/unit/dso_reconciler/test_inbound_leaf_bodies.py

---

Walkthrough

This PR extends the DSO reconciler's applier to deduplicate inbound Jira CREATE mutations by consulting a binding store before materializing local tickets. The typed dispatcher was enhanced to inspect handler signatures and selectively pass context parameters, and the deduplication behavior is validated by new tests and regression coverage.

Changes

Inbound CREATE deduplication via binding_store

Layer / File(s)	Summary
Inbound CREATE dedup guard and signature plugins/dso/scripts/dso_reconciler/applier.py	Inbound CREATE leaf accepts optional binding_store parameter. When the store indicates a Jira key is already bound, the leaf writes the mapping to bridge_state/mapping.json atomically and returns dedup_skipped instead of materializing a duplicate ticket.
Dispatcher signature inspection and binding_store threading plugins/dso/scripts/dso_reconciler/applier.py	_apply_typed now inspects handler signatures to determine if they accept binding_store and/or repo_root (including **kwargs support), then passes only supported arguments. Both the typed-single-mutation apply() path and the inbound typed dispatch loop now forward binding_store to the dispatcher.
Test infrastructure and dedup regression coverage tests/unit/dso_reconciler/test_inbound_leaf_bodies.py	Introduces _patch_apply_deps() to stub applier dependency loaders (_load_acli, _load_concurrency) for offline test execution. Two existing suppress-pair tests updated to use the stub. New regression test verifies inbound CREATE dedupes pre-bound keys, writes the mapping atomically, and does not create phantom ticket directories; also confirms unbound keys still materialize.

Shell test infrastructure mktemp fix

Layer / File(s)	Summary
mktemp platform-portable fix plugins/dso/scripts/dso_reconciler/e2e_field_validation_probe.sh	run_reconciler() now allocates the reconciler log side-car using mktemp /tmp/recon-probe.XXXXXX.log with comments on macOS/GNU -t flag semantics, replacing the previous -t form.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• navapbc/digital-service-orchestra#407: Loads and routes binding store through reconcile/applier pipeline; complements this PR by feeding binding store into dedup-aware inbound CREATE dispatch.
• navapbc/digital-service-orchestra#375: Prior signature-aware threading of repo_root into typed handlers; this PR extends the same pattern to support binding_store.
• navapbc/digital-service-orchestra#371: Routes typed inbound mutations through _apply_typed dispatcher; this PR builds on that foundation by threading binding_store for dedup behavior.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch staged-2c3b33832330-1780719283

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

This PR adds a defense-in-depth deduplication guard for inbound Jira CREATE mutations when the Jira key is already bound in bindings.json, preventing accidental duplicate local ticket materialization during a narrow snapshot/label write-back transient. It also updates unit tests to run applier.apply() in offline/all-inbound contexts by stubbing lazy loaders, and improves mktemp portability in an e2e probe script.

Changes:

• Plumb binding_store through typed-mutation dispatch and add an inbound-create early-exit that records mapping.json and skips local materialization when the Jira key is already bound.
• Add unit coverage for the bound-key inbound CREATE dedup behavior and patch unit tests to stub _load_acli() / _load_concurrency() for offline typed-inbound apply runs.
• Replace mktemp -t usage with an explicit /tmp/...XXXXXX... template to avoid macOS/GNU semantic divergence.

Security overlay: Not warranted by this diff (no new auth/trust-boundary changes; mostly local state writes).
Performance overlay: Not warranted by this diff (adds a single local binding-store lookup and an atomic mapping write on an early-return path).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/unit/dso_reconciler/test_inbound_leaf_bodies.py	Adds offline stubs for apply() dependencies and new test asserting inbound CREATE dedups when binding exists.
plugins/dso/scripts/dso_reconciler/e2e_field_validation_probe.sh	Updates mktemp invocation to a portable template form.
plugins/dso/scripts/dso_reconciler/applier.py	Adds binding-store-aware inbound CREATE dedup guard and threads binding_store through typed dispatch/apply.