Revert "FEAT: add prompt suffix handling" - #136
Merged
michelle-hadfield-nava merged 1 commit intoJan 9, 2026
Merged
Conversation
This reverts commit bd38d76.
michelle-hadfield-nava
deleted the
revert-134-mHadfield/1403_add_prompt_suffix_handling
branch
January 9, 2026 23:10
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 54.73% | 376/687 |
| 🔴 | Branches | 49.8% | 122/245 |
| 🔴 | Functions | 59.63% | 65/109 |
| 🔴 | Lines | 54.53% | 355/651 |
Test suite run success
78 tests passing in 7 suites.
Report generated by 🧪jest coverage report action from 55da58c
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reverts PR #134, removing the prompt suffix handling feature that was previously added. The revert removes the ability to pass a suffix parameter to customize prompt names dynamically.
Key changes:
- Removed
suffixparameter from frontend and backend APIs - Restored prompt template retrieval to use a single prompt name without suffix concatenation
- Reverted prompt version IDs in the configuration to earlier versions
- Simplified request body construction in multiple files
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
frontend/src/util/fetchResources.ts |
Removed suffix parameter and simplified request body construction |
frontend/src/util/fetchActionPlan.ts |
Simplified request body from separate object to inline construction |
frontend/src/components/ResourcesList.tsx |
Formatting-only change collapsing multi-line span element to single line |
frontend/src/app/[locale]/generate-referrals/page.tsx |
Removed extraction and passing of suffix query parameter |
app/src/pipelines/generate_referrals/pipeline_wrapper.py |
Removed suffix parameter from run_api and _run methods, updated error message |
app/src/pipelines/generate_action_plan/pipeline_wrapper.py |
Moved prompt template retrieval from _run to setup, changed ChatPromptBuilder to use required_variables instead of variables |
app/src/common/haystack_utils.py |
Removed suffix parameter from get_phoenix_prompt function |
app/src/app_config.py |
Reverted prompt version IDs to earlier versions and removed generate_referrals_keystone entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #134
Preview environment for frontend
♻️ Environment destroyed ♻️
Preview environment for app
♻️ Environment destroyed ♻️