docs: Add notes about scalability and thread-safety - #80
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses thread-safety issues in the pipeline components by removing stateful instance variables that could cause race conditions when the same component instance is shared across multiple threads handling concurrent API requests.
Key changes:
- Removed stateful
attempt_counttracking fromLlmOutputValidatorcomponent to ensure thread-safety - Added documentation clarifying thread-safety requirements for pipeline components
- Added comments explaining
max_runs_per_componentbehavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/common/components.py | Removed attempt_count state variable from LlmOutputValidator to make it thread-safe; added module-level documentation about thread-safety requirements; updated error logging to remove attempt count reference |
| app/src/pipelines/generate_referrals/pipeline_wrapper.py | Added comments clarifying max_runs_per_component behavior and counter reset behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
KevinJBoyer
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Investigate Hayhooks scalability
Slack thread
Changes
Add notes about scalability and thread-safety.
Remove state from components.
Preview environment for frontend
♻️ Environment destroyed ♻️
Preview environment for app
♻️ Environment destroyed ♻️