Skip to content

fix: backend: Allow null website for resources - #82

Merged
yoomlam merged 2 commits into
mainfrom
yl/null-website
Oct 31, 2025
Merged

fix: backend: Allow null website for resources#82
yoomlam merged 2 commits into
mainfrom
yl/null-website

Conversation

@yoomlam

@yoomlam yoomlam commented Oct 31, 2025

Copy link
Copy Markdown
Collaborator

Ticket

Slack

Changes

Update backend to allow null website for resources

The frontend appears to support null website:

Preview environment for frontend

♻️ Environment destroyed ♻️

Preview environment for app

♻️ Environment destroyed ♻️

Copilot AI review requested due to automatic review settings October 31, 2025 01:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Resource model to make the website field optional instead of required. This change allows resources to be created without a website, which is a more realistic representation since not all resources may have a website.

  • Made the website field optional in the Resource class by changing from str to Optional[str] = None
  • Updated the JSON schema string to reflect that website can be null using TypeScript union syntax string | null

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread app/src/pipelines/generate_referrals/pipeline_wrapper.py Outdated
Co-authored-by: Kevin Boyer <kevinboyer@navapbc.com>
@yoomlam
yoomlam merged commit 941c991 into main Oct 31, 2025
9 of 11 checks passed
@yoomlam
yoomlam deleted the yl/null-website branch October 31, 2025 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants