Conversation
…act-reusable-USWDS-alert-viewComponent
giverm
left a comment
There was a problem hiding this comment.
Looks good! Just one comment about the role
| @@ -0,0 +1,12 @@ | |||
| <%= tag.div class: alert_classes, role: (error? ? "alert" : nil), style: style do %> | |||
There was a problem hiding this comment.
Some of these have "role=status", which I think we'll want to preserve for accessibility.
There was a problem hiding this comment.
Yea that makes sense. Right now I see most of them either have role as status or alert except for one. I am wondering if all these alerts should be either one or the other. And as stated in the ticket only type error should alert? so would just be a change to make the role one or the other. instead of preserving it on the view side of things
There was a problem hiding this comment.
TLDR: do we need more than 2 roles / expecting nil roles or can we just update the code under the comment to just be alert or status?
Ticket
Resolves OSCER-368
Changes
Context for reviewers
Testing
BEFORE for empty password:

AFTER:

(Same outcome)
Preview environment for reporting-app