Closed
Conversation
MichaelCrawfordNava
requested changes
Mar 12, 2025
MichaelCrawfordNava
left a comment
There was a problem hiding this comment.
Just a couple of things:
- L15 in new.html.erb seems to reference role (I'm assuming user role)
- L16 in auth.md mentions user roles
- Multiple of the CI checks seem to have failed, but upon looking it seems to be for reasons outside of this PR, so I'm assuming those should just be ignored for now?
Collaborator
Author
|
@MichaelCrawfordNava CI checks were failing for a different reason that's been fixed on |
Collaborator
Author
|
Done in this commit navapbc/template-application-rails@5e2a120 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
n/a
Changes
Context for reviewers
Cleaning up all the references to roles including the applicant and employer roles. Simple applications may only ever have one role so this is not needed.
Cleaning out the roles from the migrations will be more complicated. I'll want to remove the migrations from the rails template and then recreate the schema.
Testing
Tested locally. Testing on preview environment:
homepage
create account page
sign in page
verify account page
mfa preferences page
landing page
Preview environment for app-rails
♻️ Environment destroyed ♻️
Preview environment for app
♻️ Environment destroyed ♻️