Skip to content

Remove roles#186

Closed
lorenyu wants to merge 8 commits intomainfrom
lorenyu/accountcreation
Closed

Remove roles#186
lorenyu wants to merge 8 commits intomainfrom
lorenyu/accountcreation

Conversation

@lorenyu
Copy link
Copy Markdown
Collaborator

@lorenyu lorenyu commented Mar 7, 2025

Ticket

n/a

Changes

  • Remove user role and references to it
  • Remove references to applicant or employer or superadmin

Context for reviewers

Cleaning up all the references to roles including the applicant and employer roles. Simple applications may only ever have one role so this is not needed.

⚠️ Migration notes

Cleaning out the roles from the migrations will be more complicated. I'll want to remove the migrations from the rails template and then recreate the schema.

Testing

Tested locally. Testing on preview environment:

homepage image
create account page image
sign in page image
verify account page image
mfa preferences page image
landing page image

Preview environment for app-rails

♻️ Environment destroyed ♻️

Preview environment for app

♻️ Environment destroyed ♻️

Copy link
Copy Markdown

@MichaelCrawfordNava MichaelCrawfordNava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of things:

  1. L15 in new.html.erb seems to reference role (I'm assuming user role)
  2. L16 in auth.md mentions user roles
  3. Multiple of the CI checks seem to have failed, but upon looking it seems to be for reasons outside of this PR, so I'm assuming those should just be ignored for now?

@lorenyu
Copy link
Copy Markdown
Collaborator Author

lorenyu commented Mar 12, 2025

@MichaelCrawfordNava CI checks were failing for a different reason that's been fixed on main, I pulled in changes from main which should fix most of those except the anchore-scan failure which I think we should ignore for now

Copy link
Copy Markdown

@MichaelCrawfordNava MichaelCrawfordNava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lorenyu
Copy link
Copy Markdown
Collaborator Author

lorenyu commented Mar 12, 2025

Done in this commit navapbc/template-application-rails@5e2a120
(I accidentally pushed to main instead of making a PR)

@lorenyu lorenyu closed this Mar 12, 2025
@lorenyu lorenyu deleted the lorenyu/accountcreation branch March 12, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants