Skip to content

⚠️ Remove create user roles migration#193

Closed
lorenyu wants to merge 1 commit intomainfrom
lorenyu/rmmigration
Closed

⚠️ Remove create user roles migration#193
lorenyu wants to merge 1 commit intomainfrom
lorenyu/rmmigration

Conversation

@lorenyu
Copy link
Copy Markdown
Collaborator

@lorenyu lorenyu commented Mar 14, 2025

Ticket

n/a

Changes

see title

Context for reviewers

This commit navapbc/template-application-rails@5e2a120 removes the user roles from the application code but not from the database. This PR removes it from migrations. This was separated out since removing an already existing migration is not backwards compatible. Since this is a template it makes sense to do it this way rather than add an extra migration that removes the user_roles table.

Migration notes

When updating the template in this version, revert the changes in these files:

  • <APP_NAME>/db/migrate/20240410213056_create_user_roles.rb (deleted in this change)
  • <APP_NAME>/db/schema.rb (user_tables removed)

Testing

Removed the "create_user_roles" migration file and regenerated schema.db by running make db-reset, make clean-volumes, and make init-db in app-rails app

Preview environment for app

♻️ Environment destroyed ♻️

Preview environment for app-rails

♻️ Environment destroyed ♻️

@lorenyu
Copy link
Copy Markdown
Collaborator Author

lorenyu commented Mar 19, 2025

@lorenyu lorenyu closed this Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant