Closed
Conversation
LeslieJAnderson
force-pushed
the
enable-local-login-for-dev-env
branch
from
ff70643 to
90b4c27
Compare
lorenyu
reviewed
Apr 29, 2025
Collaborator
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
Awesome thanks! I love how simple this is. I had a question about whether we can make it even simpler by consolidating the mock adapter with the local adapter into one. It feels like they are both pretty simple and we could combine somehow.
LeslieJAnderson
force-pushed
the
enable-local-login-for-dev-env
branch
from
bd8b5f8 to
03bf477
Compare
lorenyu
reviewed
May 2, 2025
Collaborator
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
Left some comments. Main thing is how the config/env vars is set
lorenyu
approved these changes
May 3, 2025
Collaborator
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
Thanks! I think this is ready to move over to template-application-rails to merge from there, then we can close this PR since once we merge there it will automatically propagate the changes to platform-test
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves navapbc/template-application-rails#55
Changes
Context for reviewers
Testing
Preview environment for app
Preview environment for app-rails
♻️ Environment destroyed ♻️