-
Notifications
You must be signed in to change notification settings - Fork 2
Add Lookbook #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Add Lookbook #205
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
82f88b9
Add lookbook
lorenyu bacc742
Add breadcrumbs preview
lorenyu 6d6c812
Configure lookbook preview paths
lorenyu 26d5dd2
Mount lookbook
lorenyu a670f3a
Fix partial paths
lorenyu f939239
Add component_preview layout
lorenyu 01db00d
Only enable lookbook in local and dev
lorenyu 15e9ab7
Tweak URL
lorenyu c97ffb5
Simplify component_preview
lorenyu 1ed06bc
Lint
lorenyu ed16bf7
Fix env var
lorenyu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| class BreadcrumbsPreview < Lookbook::Preview | ||
| layout "component_preview" | ||
|
|
||
| def default | ||
| render template: "application/_breadcrumbs", locals: { crumbs: [ | ||
| { name: "Passport applications", url: "default" } | ||
| ], current_name: "New passport application" } | ||
| end | ||
| end | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,12 +29,12 @@ | |
| <% end %> | ||
|
|
||
| <li class="usa-nav__primary-item"> | ||
| <%= render partial: "language-toggle", locals: { container_class: "display-block desktop:display-none relative" } %> | ||
| <%= render partial: "application/language-toggle", locals: { container_class: "display-block desktop:display-none relative" } %> | ||
|
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We need to explicitly set partial paths rather than rely on Rails fallback behavior. This is probably better practice anyways, easier to read/find things for the reader |
||
| </li> | ||
| </ul> | ||
| </div> | ||
| </nav> | ||
|
|
||
| <%= render partial: "language-toggle", locals: { container_class: "usa-language-container display-none desktop:display-block" } %> | ||
| <%= render partial: "application/language-toggle", locals: { container_class: "usa-language-container display-none desktop:display-block" } %> | ||
| </div> | ||
| </header> | ||
| </header> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <%# Layout for Lookbook previews of component partials %> | ||
| <!DOCTYPE html> | ||
| <html lang="<%= I18n.locale %>"> | ||
| <head> | ||
| <meta name="viewport" content="width=device-width,initial-scale=1"> | ||
| <%= stylesheet_link_tag "application", "data-turbo-track": "reload" %> | ||
| <%= javascript_importmap_tags %> | ||
| <%= javascript_include_tag '@uswds/uswds/dist/js/uswds-init.min.js' %> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div class="display-flex flex-column minh-viewport"> | ||
| <main id="main-content" class="grid-col-fill display-flex flex-column"> | ||
| <div class="grid-col-fill <%= yield :main_col_class %>"> | ||
| <div class="grid-container"> | ||
| <%= content_for?(:content) ? yield(:content) : yield %> | ||
| </div> | ||
| </div> | ||
| </main> | ||
| </div> | ||
|
|
||
| <%= javascript_include_tag '@uswds/uswds/dist/js/uswds.min.js' %> | ||
| </body> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Rails.application.configure do | ||
| config.lookbook.preview_paths = [ Rails.root.join("app", "previews") ] | ||
| end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
render partial: "application/breadcrumbs"not supported by lookbook so userender template:and remember to prefix with _ and set layout to "component_preview" to get rid of application layout