Skip to content

942 replace pinpoint with SES#231

Merged
sean-navapbc merged 10 commits intomainfrom
seant/942
Oct 23, 2025
Merged

942 replace pinpoint with SES#231
sean-navapbc merged 10 commits intomainfrom
seant/942

Conversation

@sean-navapbc
Copy link
Copy Markdown
Contributor

@sean-navapbc sean-navapbc commented Oct 17, 2025

Ticket

Resolves #{TICKET NUMBER OR URL}

Changes

What was added, updated, or removed in this PR.

Context for reviewers

Testing instructions, background context, more in-depth details of the implementation, and anything else you'd like to call out or ask reviewers.

Testing

Provide evidence that the code works as expected. Explain what was done for testing and the results of the test plan. Include screenshots, GIF demos, shell commands or output to help show the changes working as expected. ProTip: you can drag and drop or paste images into this textbox.

Preview environment for app-nextjs

Preview environment for app-flask

♻️ Environment destroyed ♻️

Preview environment for app

♻️ Environment destroyed ♻️

Preview environment for app-rails

♻️ Environment destroyed ♻️

Copy link
Copy Markdown
Contributor

@doshitan doshitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to pass the configuration set around do we? It should be set as the default for the sender already in infra/modules/notifications-email-domain/resources/main.tf.

We'll need to update various docs and comments (anywhere mentioning "Pinpoint"). But that could just be on the template PR.

Comment thread infra/modules/notifications/resources/access_control.tf Outdated
Comment thread infra/modules/notifications/resources/email.tf Outdated
Copy link
Copy Markdown
Contributor

@doshitan doshitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be working well via https://p-231-app-dev-1629703657.us-east-1.elb.amazonaws.com/email-notifications, which looks to be using the new config.

Can probably open up the template PR at this point.

Comment thread infra/modules/notifications-email-domain/data/outputs.tf Outdated
Comment thread infra/modules/notifications-email-domain/resources/access_control.tf Outdated
@sean-navapbc sean-navapbc requested a review from doshitan October 20, 2025 13:11
@sean-navapbc
Copy link
Copy Markdown
Contributor Author

I don't think we need to pass the configuration set around do we? It should be set as the default for the sender already in infra/modules/notifications-email-domain/resources/main.tf.

We'll need to update various docs and comments (anywhere mentioning "Pinpoint"). But that could just be on the template PR.

It's set as default on line 15 of infra/modules/notifications-email-domain/resources/main.tf

Sean Thomas and others added 10 commits October 22, 2025 16:42
- Replace pinpoint_app_id output with ses_configuration_set and ses_from_email
- Updates outputs for all app templates (app, app-flask, app-nextjs, app-rails)
- Completes migration from Amazon Pinpoint to direct SES usage

Related to Amazon Pinpoint end of support (October 30, 2026)
See: https://docs.aws.amazon.com/pinpoint/latest/userguide/migrate.html

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@sean-navapbc sean-navapbc merged commit 0f736ed into main Oct 23, 2025
49 of 51 checks passed
@sean-navapbc sean-navapbc deleted the seant/942 branch October 23, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants