Skip to content

Add infra for Catala app#264

Merged
lamroger-nava merged 14 commits intomainfrom
roger/catala-infra
Apr 2, 2026
Merged

Add infra for Catala app#264
lamroger-nava merged 14 commits intomainfrom
roger/catala-infra

Conversation

@lamroger-nava
Copy link
Copy Markdown
Contributor

@lamroger-nava lamroger-nava commented Mar 27, 2026

Changes

Added infra with nava-platform infra add-app . app-catala.

Context for reviewers

Goal for Q1 is a deployable Catala API

Testing

Inited and updated build repo and service

Screenshot 2026-03-27 at 12 18 00 PM

Preview environment for app

♻️ Environment destroyed ♻️

Preview environment for app-nextjs

♻️ Environment destroyed ♻️

Preview environment for app-flask

♻️ Environment destroyed ♻️

Preview environment for app-rails

♻️ Environment destroyed ♻️

Preview environment for app-catala

♻️ Environment destroyed ♻️

@lamroger-nava lamroger-nava marked this pull request as ready for review March 27, 2026 19:23
@lamroger-nava lamroger-nava requested a review from a team March 27, 2026 19:23
Comment thread .strata-template-rules-engine-catala/app-catala.yml Outdated
Comment thread e2e/app-catala/tests/index.spec.ts Outdated
Copy link
Copy Markdown
Contributor

@doshitan doshitan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A little clean up and some config tweaks are needed I think.

Comment thread infra/app-catala/app-config/dev.tf Outdated
Comment thread .dockleignore Outdated
Comment thread .grype.yml Outdated
- vulnerability: GHSA-v8gr-m533-ghj9
- vulnerability: GHSA-mq26-g339-26xf
- vulnerability: GHSA-3ww4-gg4f-jr7f
# We dont use imaplib
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid app-specific things here in the project config. This might be true for app-catala, but not other apps.

Copy link
Copy Markdown
Contributor Author

@lamroger-nava lamroger-nava Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - should we remove the above ones too in a separate PR?

Comment thread .github/workflows/cd-app-catala.yml Outdated
Comment thread .strata-template-rules-engine-catala/app-catala.yml Outdated
Comment thread e2e/app-catala/tests/index.spec.ts Outdated
Comment thread infra/app-catala/app-config/env-config/environment_variables.tf
@lamroger-nava lamroger-nava requested a review from doshitan March 31, 2026 21:01
@lamroger-nava lamroger-nava merged commit 0ddfcaf into main Apr 2, 2026
48 of 51 checks passed
@lamroger-nava lamroger-nava deleted the roger/catala-infra branch April 2, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants