Add duplicate-check step to create-issue skill - #31
Merged
Conversation
The skill ran straight from template choice to filing, so a new issue duplicating an open one slipped through unless a human happened to ask (as with the docs-spec finding that duplicated #2 during PR #4). Add a search step ahead of drafting: search all issues by keyword, judge by the work rather than a shared topic, and get explicit confirmation before filing over a known potential duplicate. Sync the phase-listing pointers in AGENTS.md and CONTRIBUTING.md and the skill description so none drift. Closes #19
Collaborator
Author
Code reviewFound 1 issue:
strata-documentation-engine/skills/create-issue/SKILL.md Lines 28 to 31 in 4e83b4e 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
4 tasks
Code review on PR #31 caught that gh issue list never returns PRs, whatever its --state, so the step could not do what it claimed: catch a PR that is already doing the work. Switch to gh search issues --include-prs, which spans both, and omit --state to cover open and closed. Also require confirmation before closing an issue as a duplicate, to match the human gate the rest of the step applies to outward-facing actions.
Collaborator
Author
baonguyenNava
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
create-issueskill had no step to catch a duplicate before filing, so a new issue duplicating an open one passed straight through unless a human happened to ask.Closes #19
How
A new Step 1, "Check for duplicates," runs ahead of template selection: search all issues by keyword with
gh issue list --state all --search, judge by whether the same work is already tracked rather than a shared topic, and handle three outcomes: comment on or update an open near-duplicate instead of filing; note in the body why a still-warranted new issue is not a duplicate; or get explicit confirmation from the person at the keyboard before filing over a plausible duplicate. Closing an issue as a duplicate applies the existingduplicatelabel. The remaining steps renumber 2 through 6. The phase-listing pointers inAGENTS.mdandCONTRIBUTING.mdand the skill's frontmatter description are synced to include the new step.Test plan
duplicatelabel already exists in the repo.Notes for reviewers
The
create-prcounterpart of this gate, raised in an issue comment, is deliberately left to #27. No runtime surface changed, so no tests were added.