Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 93.1% | 81/87 |
| 🟢 | Branches | 82.35% | 14/17 |
| 🟢 | Functions | 93.33% | 14/15 |
| 🟢 | Lines | 93.59% | 73/78 |
Test suite run success
16 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 623accb
| </head> | ||
| <div>healthy</div> | ||
| </> | ||
| ); |
There was a problem hiding this comment.
A little bit of a separate issue but this fixes an actual a11y issue
There was a problem hiding this comment.
We have a localization library in this repo - is there a reason not to use it here?
There was a problem hiding this comment.
Sure! Just added it .
I assume because we're not really refining tickets here we're not splitting them up as we might on our normal projects - first inclination is to actually break a task like that out.
There was a problem hiding this comment.
Do you mean to say that you think including content strings using the localization library should be a separate task ticketed separately?
There was a problem hiding this comment.
I think so because it's getting a bit off track of the intent of this PR
2 participants
Ticket
Resolves #347
Changes
Context for reviewers