OSCER-457: use explicit key policies

[jdettmannnava]

Ticket

Part of OSCER-457

Changes

Explicit iam policy documents added to kms keys in:

• Container image repository
• Database resources
• Database role manager
• Terraform backend S3

Context for reviewers

Upgraded checkov tests require explicit iam policies for kms keys. Added the default kms iam policy (copied from infra/modules/storage/encryption) to all our kms keys.

Unsure if it is possible to DRY this up...

Testing

Testing done in the oscer pr.

• Checkov action passes
• terraform plan showed either no changes, changes identical to main, or the removal of the "Id" attribute for key policy for:
  • infra/networks
  • infra/accounts
  • infra/reporting-app/service (dev and sandbox)
  • infra/reporting-app/database (dev and sandbox)
  • infra/reporting-app/build-repository
• Preview works normally: https://p-546-reporting-app-dev-1571286055.us-east-1.elb.amazonaws.com/

[coderabbitai]

Warning

Rate limit exceeded

@jdettmannnava has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 58 minutes and 28 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d70f0126-0588-4987-b51d-01773f3fb2bb

📥 Commits

Reviewing files that changed from the base of the PR and between ad00fcf and dc2b5e2.

📒 Files selected for processing (4)

• infra/modules/container-image-repository/main.tf
• infra/modules/database/resources/main.tf
• infra/modules/database/resources/role_manager.tf
• infra/modules/terraform-backend-s3/main.tf

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jdettmann/oscer-457-explicit-kms-policies

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jdettmannnava]

Probably requires actual architecture changes