Merged
Conversation
rocketnova
approved these changes
Apr 1, 2024
Contributor
rocketnova
left a comment
There was a problem hiding this comment.
Appreciate your make expertise here.
What do you think is the best way to maintain these guidelines going forward? Different options I can think of, but that I am not tied to:
- Add a comment about these at the top of the file
- Add a Makefile styleguide to
/docs - Add a Makefile linter (does this exist / do you know any?)
5aed3ea to
312aa78
Compare
312aa78 to
049e3e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend avoiding backticks to indicate command substitution in general and to
standardize on
$(). This can be a little confusing in a makefile which alsouses
$()to indicate its own calls, but the consistency is better in myopinion. So swap those where used.
Also, Make isn't Bash, so use explicit
shellfunction to highlight what isintended to be executed by Make.
Though
CURRENT_ACCOUNT_ALIASandCURRENT_ACCOUNT_IDalso don't appear to beused currently, so could also be dropped.