Skip to content

makefile: Clearer script calls#574

Merged
doshitan merged 1 commit intomainfrom
doshitan/makefile-more-consistent-script
Feb 24, 2026
Merged

makefile: Clearer script calls#574
doshitan merged 1 commit intomainfrom
doshitan/makefile-more-consistent-script

Conversation

@doshitan
Copy link
Copy Markdown
Contributor

Recommend avoiding backticks to indicate command substitution in general and to
standardize on $(). This can be a little confusing in a makefile which also
uses $() to indicate its own calls, but the consistency is better in my
opinion. So swap those where used.

Also, Make isn't Bash, so use explicit shell function to highlight what is
intended to be executed by Make.

Though CURRENT_ACCOUNT_ALIAS and CURRENT_ACCOUNT_ID also don't appear to be
used currently, so could also be dropped.

Copy link
Copy Markdown
Contributor

@rocketnova rocketnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate your make expertise here.

What do you think is the best way to maintain these guidelines going forward? Different options I can think of, but that I am not tied to:

  • Add a comment about these at the top of the file
  • Add a Makefile styleguide to /docs
  • Add a Makefile linter (does this exist / do you know any?)

@doshitan doshitan force-pushed the doshitan/makefile-more-consistent-script branch from 5aed3ea to 312aa78 Compare January 23, 2025 15:36
@doshitan doshitan force-pushed the doshitan/makefile-more-consistent-script branch from 312aa78 to 049e3e3 Compare February 24, 2026 17:41
@doshitan doshitan requested a review from a team as a code owner February 24, 2026 17:41
@doshitan doshitan merged commit d38e5f2 into main Feb 24, 2026
1 check passed
@doshitan doshitan deleted the doshitan/makefile-more-consistent-script branch February 24, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants