Skip to content

Add SSM-based feature flags#873

Merged
lorenyu merged 8 commits intomainfrom
lorenyu/ffs
Feb 20, 2025
Merged

Add SSM-based feature flags#873
lorenyu merged 8 commits intomainfrom
lorenyu/ffs

Conversation

@lorenyu
Copy link
Copy Markdown
Contributor

@lorenyu lorenyu commented Feb 12, 2025

Ticket

Resolves #781

Changes

  • Add modules/feature_flags
  • Add feature_flags_config in app-config/env-config/feature_flags.tf with ability to override per environment via feature_flags_override
  • Create feature flags as SSM parameters in infra/<app_name>/service/feature_flags.tf
  • Add feature flags as environment variables with FF_ prefix

Context for reviewers

Re-adding feature flag support using SSM params and environment variables

Testing

see navapbc/platform-test#178

@@ -0,0 +1,4 @@
output "ssm_parameter_arns" {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not blocking, but given this is tied to SSM/returns ARNs, I wonder if we should name the module like ssm_feature_flags or feature_flags__ssm (assuming we eventually develop a "feature_flag" interface of which this is one implementation) or something?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. It'd be nice to have module names be independent of cloud service provider, so we can have AWS and Azure modules be the same. Interesting idea, I'll leave it as is for now and we can think about ti more.

lorenyu and others added 4 commits February 19, 2025 16:01
Co-authored-by: Tanner Doshier <git@doshitan.com>
Co-authored-by: Tanner Doshier <git@doshitan.com>
@lorenyu lorenyu merged commit c805160 into main Feb 20, 2025
11 checks passed
@lorenyu lorenyu deleted the lorenyu/ffs branch February 20, 2025 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate away from AWS Evidently

2 participants