Merged
Conversation
doshitan
reviewed
Feb 18, 2025
| @@ -0,0 +1,4 @@ | |||
| output "ssm_parameter_arns" { | |||
Contributor
There was a problem hiding this comment.
Not blocking, but given this is tied to SSM/returns ARNs, I wonder if we should name the module like ssm_feature_flags or feature_flags__ssm (assuming we eventually develop a "feature_flag" interface of which this is one implementation) or something?
Contributor
Author
There was a problem hiding this comment.
Hmm. It'd be nice to have module names be independent of cloud service provider, so we can have AWS and Azure modules be the same. Interesting idea, I'll leave it as is for now and we can think about ti more.
Co-authored-by: Tanner Doshier <git@doshitan.com>
Co-authored-by: Tanner Doshier <git@doshitan.com>
This was referenced Feb 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #781
Changes
Context for reviewers
Re-adding feature flag support using SSM params and environment variables
Testing
see navapbc/platform-test#178