Skip to content

Add ability to run task commands in PR environment#879

Merged
lorenyu merged 1 commit intomainfrom
lorenyu/prtasks
Feb 22, 2025
Merged

Add ability to run task commands in PR environment#879
lorenyu merged 1 commit intomainfrom
lorenyu/prtasks

Conversation

@lorenyu
Copy link
Copy Markdown
Contributor

@lorenyu lorenyu commented Feb 22, 2025

Ticket

Resolves #718
Resolves #878

Changes

  • Add optional parameter --workspace <workspace_name> to bin/run-command
  • Fix bug where run-command ignored environment parameter and just ran in currently initialized environment

Context for reviewers

This feature makes it possible to test changes to background jobs in a PR environment by using the run-command script

Testing

See navapbc/platform-test#181

@lorenyu lorenyu merged commit 5cc1f4d into main Feb 22, 2025
9 checks passed
@lorenyu lorenyu deleted the lorenyu/prtasks branch February 22, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix run-command to run in the specified environment Run task commands in PR environment

1 participant