Conversation
lorenyu
approved these changes
Feb 25, 2025
Contributor
lorenyu
left a comment
lorenyu
left a comment
There was a problem hiding this comment.
For something like this where you are (1) sure there's no risk of regressions, (2) sure there'd be no issues from peer review and (3) there's little value in spreading awareness of it, I wouldn't mind if you pushed straight to main (or alternatively if you want to be more conservative, create a PR to let CI run, and then just merge, bypassing reviews)
That said I also don't mind reviewing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while going through http://github.com/HHS/simpler-grants-gov/pull/3925/ line by line