Skip to content

Move monitoring config out of service root module#884

Merged
lorenyu merged 1 commit intomainfrom
lorenyu/monitoringconfig
Feb 28, 2025
Merged

Move monitoring config out of service root module#884
lorenyu merged 1 commit intomainfrom
lorenyu/monitoringconfig

Conversation

@lorenyu
Copy link
Copy Markdown
Contributor

@lorenyu lorenyu commented Feb 28, 2025

Ticket

Resolves #547

Changes

  • Create new env-config object monitoring_config defined in monitoring.tf
  • Move incident_management_service_integration config to monitoring_config as incident_management_service attribute
  • Rename email_alerts_subscription_list to email_alert_recipients

Context for reviewers

Tech debt to clean up the configuration for monitoring

Testing

See navapbc/platform-test#183

@lorenyu lorenyu merged commit e95981c into main Feb 28, 2025
9 checks passed
@lorenyu lorenyu deleted the lorenyu/monitoringconfig branch February 28, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move monitoring config out of service root module

1 participant