Merged
Conversation
rylew1
commented
Mar 20, 2025
|
|
||
| - name: Install dependencies | ||
| if: steps.cache-node.outputs.cache-hit != 'true' | ||
| run: make e2e-setup-ci |
Contributor
Author
There was a problem hiding this comment.
is there a way we don't have to repeat the common setup steps for both jobs?
Contributor
Author
There was a problem hiding this comment.
what about the matrix strategy:
jobs:
static-checks:
name: ${{ matrix.check.name }}
runs-on: ubuntu-latest
strategy:
matrix:
check:
- name: Format
command: make e2e-format-check-native
- name: Typecheck
command: make e2e-type-check-native
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: lts/*
- name: Cache Node.js dependencies
id: cache-node
uses: actions/cache@v4
with:
path: e2e/node_modules
key: ${{ runner.os }}-node-${{ hashFiles('package-lock.json') }}
- name: Install dependencies
if: steps.cache-node.outputs.cache-hit != 'true'
run: make e2e-setup-ci
- name: ${{ matrix.check.name }}
run: ${{ matrix.check.command }}
Contributor
There was a problem hiding this comment.
Good idea sounds good to me
lorenyu
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #813
Changes
fail-fast:falseto allow all e2e static checks to run regardless of one failureworkflow_dispatchto manually trigger static checks [to be tested post merge]Context
The e2e format and typecheck calls were in the same GHA job - this PR just separates them to separate jobs so they can run in parallel.