Open
Conversation
lorenyu
reviewed
Mar 24, 2025
Contributor
lorenyu
left a comment
There was a problem hiding this comment.
i think the ADR is conflating two things:
- whether or not to use the OpenTelemetry protocol vs use vendor-specific protocols
- which implementation of the OpenTelemetry protocol to use
i think those two things should be more clearly separated. for "whether to use OTLP", i think it's clear we should use OpenTelemetry protocol because:
- it abstracts away the monitoring service which decouples the monitoring service from the application, reducing lock-in
- most monitoring services accept it and some require it
the downside is that (a) there's an extra layer of indirection which adds some complexity to the architecture and (b) in many cases requires a separate container rather than direct integration with the monitoring service through an SDK. (i'm not sure about (b) you may want to verify my reasoning).
for "which implementation of OTLP", fluentbit says they support the opentelemetry protocol so i think it's a choice between OpenTelemetry Collector and Fluent Bit (not sure if there are others). i'd like to see some pros/cons of the implementations, and happy to go with whatever you choose. can also ask others at Nava to see what they think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #715