3pt line to be circular arc, not elliptical#7
Open
basketball-stats wants to merge 3 commits into
Open
Conversation
Also minor fix to rim dimensions
fixed 3pt line arc with 5'3 distance center to baseline
fixed rim center position to 5'3 from baseline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think there is an issue with how the 3pt arc is drawn in the
create_courtfunction, it's elliptical instead of circular.This pull request is to fix it (also a minor fix to rim dimension).
I have fixed it in my project (can find it at this github link.
See this gist for a visual comparison. The gist is based on a different codebase (github link) but the author used your code
Note: I have not updated the figures in the notebook