FEAT: add support for shard key in ketama hashing #1025
+214
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
requested changes
Nov 26, 2025
src/main/java/net/spy/memcached/ArcusReplKetamaNodeLocator.java
Outdated
Show resolved
Hide resolved
singsangssong
force-pushed
the
task/shard
branch
from
3c2d05c to
0b1d784
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
singsangssong
force-pushed
the
task/shard
branch
from
0b1d784 to
609d705
Compare
uhm0311
previously approved these changes
Nov 27, 2025
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
singsangssong
force-pushed
the
task/shard
branch
from
609d705 to
05d6ef7
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
singsangssong
force-pushed
the
task/shard
branch
from
05d6ef7 to
0930062
Compare
oliviarla
previously approved these changes
Dec 5, 2025
singsangssong
force-pushed
the
task/shard
branch
from
0930062 to
3e147e9
Compare
oliviarla
previously approved these changes
Dec 5, 2025
uhm0311
previously approved these changes
Dec 5, 2025
singsangssong
force-pushed
the
task/shard
branch
from
3e147e9 to
e4c2caf
Compare
Collaborator
Author
|
https://github.com/jam2in/arcus-works/issues/790#issuecomment-3629954750 위에서 코멘트 주신대로 |
uhm0311
requested changes
Dec 9, 2025
singsangssong
force-pushed
the
task/shard
branch
from
e4c2caf to
7aa0868
Compare
uhm0311
previously approved these changes
Dec 10, 2025
oliviarla
reviewed
Dec 10, 2025
| ); | ||
|
|
||
| for (String key : keys) { | ||
| assertEquals("100", replLocator.getShardKey(key)); |
Collaborator
There was a problem hiding this comment.
직접 Locator 생성해서 테스트하는 케이스(unit test)는 ArcusKetamaNodeLocatorTest 로 옮기는 게 나아보입니다.
그러면 이 클래스에서는 client쪽에서 shard key가 담긴 키에 대한 요청을 서버에 보낼 때(integration test) 어떻게 처리하는지만 검증하면 됩니다.
| } | ||
|
|
||
| @Override | ||
| public boolean getUseShardKey() { |
Collaborator
There was a problem hiding this comment.
set/get 형태 말고 enableShardKey / isShardKeyEnabled 메서드명은 어떤가요?
singsangssong
force-pushed
the
task/shard
branch
from
7aa0868 to
67e1908
Compare
Collaborator
|
|
singsangssong
force-pushed
the
task/shard
branch
from
67e1908 to
24f0d77
Compare
Collaborator
|
리뷰 가능한 상태가 되면 요청 주세요. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
⌨️ What I did
원하는 key string을 하나의 노드에 저장할 수 있도록 그룹화하는 Shard Key 기능을 구현합니다.
shard 결정을 위해서는 key의 일부만을 사용하며, 해당 조건은 아래와 같습니다.
키에
{...}패턴이 포함될 경우, 전체 키 대신{와}사이의 문자열만을 해싱하여 저장할 노드를 결정합니다.{와 처음 등장하는}사이의 하나 이상의 문자열을 해싱이를 통해 동일한 Shard Key를 가진 키들은 항상 같은 노드에 배치됨을 보장하도록 합니다.
테스트코드는 새로운
ArcusShardKeyTest클래스를 추가했습니다.