Feat/state api #923
Merged
Feat/state api #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: apply ResizeObserver to camera and panels * fix: unobserve removed panel when panel change * fix: add defense code to check if element exists * feat: add resizeObservePanel option * fix: add defensive logic to getStyle * chore: change resizeObservePanel to resizePanelObserve * fix: add unobserve panel logic * chore: update setup-node to v4
* fix: infinite resize * chore: remove route for removed demo * fix: prevent calling viewport.resize() when isResizing * chore: add type info * chore: add script to link core and framework for debug * chore: create reference demo page * fix: calculate resized size using getElementSize * feat: add optimizeSizeUpdate option * chore: disable eslint for helper script * refactor: declare variable for resizeTarget * test: changed import path to relative path * fix: changed viewport resize condition * chore: add comments --------- Co-authored-by: jinwoo-choi-05 <[email protected]>
daybrush
reviewed
Jun 16, 2025
src/state-api/index.ts
Outdated
| return percent; | ||
| }; | ||
|
|
||
| export type FlickingStateApi = ReactiveObject<{ |
Member
There was a problem hiding this comment.
아래 상태 interface가 있기도 하고, 메서드 interface를 만들고 Intersection 타입으로 만드시는게 좋을 것 같습니다.
daybrush
reviewed
Jun 16, 2025
src/state-api/index.ts
Outdated
| scrollProgress: number; | ||
| } | ||
|
|
||
| const flickingStateApiAdapter: ReactiveSetupAdapter<FlickingStateApi, FlickingReactiveState, "moveTo"> = ({ onInit, onDestroy }) => { |
Contributor
Author
There was a problem hiding this comment.
말씀주신 data 타입이라는 게 어떤 걸 말씀하시는 걸까요?
daybrush
reviewed
Jun 16, 2025
src/state-api/index.ts
Outdated
| currentPanelIndex: number; | ||
| indexProgress: number; | ||
| scrollProgress: number; | ||
| moveTo: (i: number) => Promise<void> | undefined; |
Member
There was a problem hiding this comment.
flicking instance가 없는 경우 Promise.reject를 호출해도 괜찮을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Flicking state api implementation
Details