Docs/reactive api #927
Merged
Docs/reactive api #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daybrush
reviewed
Jun 24, 2025
src/reactive/index.ts
Outdated
| * Reactive state properties for Flicking | ||
| * @ko Flicking의 반응형 상태 속성들 | ||
| * @interface | ||
| * @property {boolean} isReachStart - Whether Flicking has reached the first panel<ko>첫 번째 패널에 도달했는지 여부</ko> |
Contributor
Author
There was a problem hiding this comment.
연규님, 이 부분 빼버리면 문서에서 정보가 많이 빠지게 되는데 차라리 이건 유지하고 property에 직접 단 주석을 빼는 건 어떨까요?
@property 유지 시
@property 삭제 시
daybrush
reviewed
Jun 24, 2025
src/reactive/index.ts
Outdated
| * @property {Flicking | null} flicking - Flicking instance or null<ko>Flicking 인스턴스 또는 null</ko> | ||
| */ | ||
| export interface FlickingReactiveData { | ||
| flicking: Flicking | null; |
daybrush
approved these changes
Jun 24, 2025
cjw783
commented
Jun 26, 2025
Comment on lines
179
to
191
| const options = getProps().options; | ||
|
|
||
| // options를 고려하지 않고 초기값을 설정해도 동작에는 아무런 문제가 없으나, 이 시점의 초기값과 컴포넌트 init 단계에서의 초기값이 다르면 화면 리렌더링이 발생할 수 있으므로 | ||
| // 이렇게 미리 옵션을 통해서 예측할 수 있는 부분들은 맞춰둔다. | ||
| const reactiveObj: FlickingReactiveObject = reactive({ | ||
| isReachStart: false, // 이 값을 전달 받은 옵션을 이용해서 설정. getProps()를 통해 전달된 옵션을 사용하여 설정할 수 있습니다. | ||
| isReachEnd: false, // | ||
| totalPanelCount: 0, // | ||
| currentPanelIndex: 0, // | ||
| progress: 0, // | ||
| indexProgress: 0, // | ||
| isReachStart: (options?.defaultIndex === 0 && !options.circular), | ||
| isReachEnd: false, | ||
| totalPanelCount: 0, | ||
| currentPanelIndex: options?.defaultIndex ?? 0, | ||
| progress: 0, | ||
| indexProgress: 0, | ||
| moveTo | ||
| }); |
Contributor
Author
There was a problem hiding this comment.
@daybrush 님, 전달받은 옵션을 통해서 미리 맞춰둘 수 있는 초기값은 isReachStart, currentPanelIndex 정도인 것 같아서 이 정도로만 일단 작성했습니다.
얘기하신게 이게 맞는지 한번 확인 부탁드리고, 혹시 다른 값들도 미리 맞춰둘 수 있는 게 있다고 보시면 말씀 부탁드립니다.
malangfox
approved these changes
Jun 30, 2025
daybrush
reviewed
Jun 30, 2025
| onInit((inst, data) => { | ||
| flicking = data.flicking; | ||
| if (flicking === null) return; | ||
| if (flicking === undefined) return; |
daybrush
reviewed
Jun 30, 2025
src/reactive/index.ts
Outdated
| const reactiveObj: FlickingReactiveObject = reactive({ | ||
| isReachStart: false, | ||
| isReachStart: (options?.defaultIndex === 0 && !options.circular), | ||
| isReachEnd: false, |
Member
There was a problem hiding this comment.
totalPanelCount에 대한 options도 있었으면 좋겠습니다.
daybrush
reviewed
Jun 30, 2025
src/reactive/index.ts
Outdated
| currentPanelIndex: 0, | ||
| currentPanelIndex: options?.defaultIndex ?? 0, | ||
| progress: 0, | ||
| indexProgress: 0, |
Member
There was a problem hiding this comment.
indexProgress: options?.defaultIndex ?? 0,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details