feat: usePercentagePos 옵션 추가 & resize 비동기 사이에 사이즈가 갱신되는 문제 수정 - #957
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cjw783
reviewed
Aug 13, 2026
cjw783
left a comment
cjw783
left a comment
Contributor
There was a problem hiding this comment.
@daybrush 님, 데모 관련해서 보완이 필요할 듯 합니다.
1. 데모가 의도대로 동작하지 않는 것 같습니다.
설명을 읽어보면 데모의 스펙은
(1) toggleWidth 버튼을 누르면,
- usePercentagePos를 사용하지 않은 쪽은 패널 정렬이 깨진다.
- usePercentagePos를 사용한 쪽은 패널 정렬이 깨지지 않는다.
(2) 그리고 call resize 버튼을 누르면 두 쪽다 정상으로 돌아간다.
인걸로 보이는데요, 실제로 해보면 두 쪽 모두 정렬이 깨지지 않고 동작이 같게 나오는 것 같습니다.
2. 한글 데모 문서 추가가 필요합니다.
packages/docs/i18n/ko/docusaurus-plugin-content-docs/current/demos/advanced 에 한글 번역 문서 추가 부탁드립니다.
영어 문서에 한글 섞여 있는 부분도 있는데 리뷰 코멘트로 남겼으니 확인 부탁드립니다
Comment on lines
+45
to
+46
| - **`autoResize`와의 관계**: In real-world usage you'd keep [`autoResize`](../../api/interfaces/FlickingOptions#autoresize) enabled. `usePercentagePos` prevents the temporary misalignment between the moment the layout changes and the moment the (possibly debounced) resize call is applied. This demo disables it only to make that in-between moment observable. | ||
| - **`resizeDebounce`와의 관계**: With a large [`resizeDebounce`](../../api/interfaces/FlickingOptions#resizedebounce) value, the gap until resize is applied gets longer. `usePercentagePos` keeps panels in place during that gap. |
Contributor
There was a problem hiding this comment.
영문 데모문서인데 한글이 섞여 있습니다 ("~와의 관계" 부분)
Member
Author
|
localhost, 개발 환경에서는 @egjs/flicking 대신 로컬에 alias로 대체할 수 있게 수정하는 이슈로 다시 만들어서 반영할 예정입니다. |
malangfox
self-requested a review
September 1, 2026 06:16
Contributor
@daybrush |
cjw783
self-requested a review
September 1, 2026 06:19
cjw783
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Details