Ta i bruk tidslinje fra familie-felles i VilkårsvurderingTidslinjer #5075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vice og BehandlingstemaService(+ Test)
…idslinjer (+ Test)
bragejahren
reviewed
Feb 17, 2025
| .map { it.tilPeriodeNy() } | ||
| .tilTidslinje() | ||
|
|
||
| private fun VilkårResultat.tilPeriodeNy(): FamilieFellesPeriode<VilkårRegelverkResultat> = |
There was a problem hiding this comment.
Antar dette skal endres på sikt?
There was a problem hiding this comment.
Ja, navnene på noen av duplikatfunksjonene må være forskjellig pga jvm signature som blir like >.< Mente egentlig å bruke FamilieFelles i navnet, i stedet for Ny
bragejahren
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💰 Hva skal gjøres, og hvorfor?
Favro: NAV-23270
Bytter ut tidslinje fra ba-sak med tidslinje fra familie-felles enkelte steder.
Holder PR'ene små, så de skal være lette å lese.
Bør leses commit for commit.
Det er noe duplikatkode, men dette vil fjernes i neste PR
I noen av testene er bare importen av funksjonene som bruker tidslinje endret, så testene tester det samme, men med tidslinjene fra familie-felles