-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Økt aldersgrense (PEK-868) Magicbox -> Main #1714
Open
mlp73
wants to merge
78
commits into
main
Choose a base branch
from
magicbox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
78 commits
Select commit
Hold shift + click to select a range
8f8d03e
Visning av utvidet /person uten fungerende tester
Lucas8448 46723c8
Merge branch 'codebox' into LB-PEK-868
Lucas8448 0bfafc0
Oppdater useSelectors til å være i komponenten
Lucas8448 314b50c
Merge branch 'codebox' into LB-PEK-868
mlp73 9122b45
eksempel på hvordan man tar i bruk mocked store i test med lagret query
mlp73 a5cba6a
Refaktorering av alder.ts og alder.test.ts for å bruke mock verdier t…
Lucas8448 a21c8b7
eksempel på hvordan man tar i bruk mocked store i test med lagret que…
mlp73 37d85d5
Legger til ubetinget uttaksalder i flere komponenter og valideringsfu…
Lucas8448 db10489
Oppdaterer validasjon for avansert beregning ved å erstatte useAppSel…
Lucas8448 91f4627
Flytte selectors sammen med hverandre for lesbarhet
Lucas8448 f6e849b
korrigerer misbruk av selector
mlp73 f6174c2
korrigerer misbruk av selector
mlp73 6af845a
fjerner selectors fra hooks
mlp73 ecc17f8
korrigerer feil erstatning av DEFAULT_SENEST_UTTAKSALDER, og feil bru…
mlp73 e8c31f9
fikser import av initialValues i RedigerAvansertBeregning hooks
mlp73 9bb4a40
fikser feil parameter for å sammenligne fodselsdato i loaders
mlp73 dfd6aea
fikser import av selector i testfil og legger mock for state
mlp73 d525a19
fikser import av selector i testfil og legger mock for state
mlp73 8d739f0
fikser bruk av feil alder i GrunnlagAFP
mlp73 433b9b9
Fikse lokasjon på ubetingetUttaksalder i RedigerAvansertBeregning uti…
Lucas8448 cacc50e
Utvide typeguards til å ta høyde for udefinert pensjoneringAldre
Lucas8448 812954e
Oppdater pensjoneringsaldre og refaktoriser alder-funksjoner for bedr…
Lucas8448 a18c390
Rett opp stavefeil i kommentarer og oppdater variabelnavn for konsistens
Lucas8448 a86a018
Synkronisering med Main
Lucas8448 317014d
LB-PEK-868: PKF: Ta i bruk utvidet /person data i visning til bruker …
mlp73 240b919
Merge branch 'main' into magicbox
Lucas8448 d12a173
Delvis oppsett av tester for aldersvelger med dynamiske verdier
Lucas8448 c15b667
Merge branch 'main' into magicbox
Lucas8448 c4bd1e0
Merge branch 'main' into magicbox
Lucas8448 c82ef80
Tester av dynamiske aldersgrenser og refaktorering av gjenntatt getBr…
Lucas8448 06cbc72
Merge branch 'main' into magicbox
Lucas8448 b082248
Fikset tilbakemeldinger på tester
Lucas8448 7bfd205
Merge branch 'main' into magicbox
Lucas8448 32acff5
Merge branch 'main' into magicbox
Lucas8448 373155f
Ny util funkjson for formatering av dynamiske aldre, og liten død imp…
Lucas8448 bb72d78
omufoeretrygd.readmore.gradert.ingress dynamiske tekster
Lucas8448 0c8437e
omufoeretrygd.readmore.hel.ingress dynamiske tekster
Lucas8448 6396c88
omufoeretrygd.hel.ingress dynamiske verdier
Lucas8448 6d513d4
Merge branch 'main' into magicbox
Lucas8448 8723bbf
når bruker med uføretrygd har nådd 62 år skal den redirekteres to ste…
Lucas8448 761caf4
Bytt AFP_UFOERE_GRENSE til AFP_UFOERE_OPPSIGELSESALDER og fjerning av…
Lucas8448 405db51
Fjerne dette tar ikke kalkulatoren høyde for i Readmore
Lucas8448 6e3af30
beregning.vilkaarsproeving.intro.ikke_nok_opptjening dynamiske tekster
Lucas8448 40a182e
beregning.avansert.rediger.uttaksgrad.ufoeretrygd.validation_error dy…
Lucas8448 17b6068
fikse package lock
Lucas8448 df064f4
Fikse RedigerAvansertBeregning test og omufoeretrygd.gradert.ingress …
Lucas8448 5836b16
beregning.avansert.rediger.read_more.uttaksgrad.gradert_ufoeretrygd.b…
Lucas8448 3669838
omufoeretrygd.readmore.gradert.avansert.ingress dynamiske tekster
Lucas8448 bd03de4
forbehold.uforetrygd.ingress dynamiske tekster uten fungerende tester
Lucas8448 ae99568
Merge branch 'main' into magicbox
Lucas8448 1e5f2dc
Oppdatere snapshots og fikse prettier warnings
Lucas8448 77155d7
Oppdatere package-lock
Lucas8448 d85712a
Opprydding i tester
Lucas8448 43e2af1
Merge branch 'main' into magicbox (sanity)
Lucas8448 5988129
Merge branch 'main' into magicbox
Lucas8448 3970880
tidligstmuliguttak.info_omstillingsstoenad_og_gjenlevende dynamiske t…
Lucas8448 fd433d1
beregning.read_more.pensjonsalder.endring.body dynamiske teskster
Lucas8448 e36e142
Småfiks av prettier formattering
Lucas8448 b2882a4
Merge branch 'main' into magicbox
Lucas8448 b99dae5
Revert "Merge branch 'main' into magicbox"
Lucas8448 29390d2
Revert "Revert "Merge branch 'main' into magicbox""
Lucas8448 22dcc00
Fikse merge feil
Lucas8448 bb15bea
Merge branch 'main' into magicbox
Lucas8448 092759a
Endre UbetingetUttaksalder til NormertPensjonsalder
Lucas8448 a7d3e23
Rename OkteAldersgrenser til OekteAldersgrenser
Lucas8448 bb255b8
Merge branch 'main' into magicbox
Lucas8448 0fd4bb1
Oppdater devtypes med manglende felt
Lucas8448 16d34d1
Merge branch 'main' into magicbox
mlp73 da27f53
tilpasser Forbehold til å hente person selv i tilfelle brukeren navig…
mlp73 0c87b62
Merge branch 'main' into magicbox
Lucas8448 379dbd6
Oppdater Readmore-tekst i tidligst uttak med at kalkulatoren ikke tar…
Lucas8448 ba9bfdf
Foreslått løsning til AgePicker, brukere med gradert og 100 % UT
Lucas8448 41d0cfd
Fjerne debugger statement
Lucas8448 0659c78
reverterer feil refaktor og korrigerer skrivefeil
mlp73 24b18c5
refaktorerer getBrukerensAlderPlus1Maaned funksjonen og legger til fe…
mlp73 54f70b8
tilpasser cypress testcase for endring til brukers alder + 1 md
mlp73 b4bfe32
justerer logikken for visning av vilkår ikke oppfylt på Enkelt
mlp73 6fc1e46
faser ut diplikatfunksjon for formatering av alder
mlp73 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -89,10 +89,16 @@ export const isAlderLikEllerOverAnnenAlder = ( | |
} | ||
} | ||
|
||
export const isAlderOverAnnenAlder = (alder: Alder, alder2: Alder) => { | ||
if (alder.aar > alder2.aar) { | ||
export const isAlderOverAnnenAlder = ( | ||
storsteAlder: Alder, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. stoersteAlder istedenfor storsteAlder |
||
minsteAlder: Alder | ||
) => { | ||
if (storsteAlder.aar > minsteAlder.aar) { | ||
return true | ||
} else if (alder.aar === alder2.aar && alder.maaneder > 0) { | ||
} else if ( | ||
storsteAlder.aar === minsteAlder.aar && | ||
storsteAlder.maaneder > minsteAlder.maaneder | ||
) { | ||
return true | ||
} else { | ||
return false | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logikken som ble refaktoret bør gjenspeile forrige logikk:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Logikken ble forsåvidt flyttet over til
getBrukerensAlderPlus1Maaned
i alder.ts ser jeg. Så det der er en dobbelimplementasjon.