Open
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request refactors the opplæringspenger-soknad application to shift terminology from "arbeidstid" (work time) to "fravær" (absence), updates the design system CSS classes from navds- to aksel-, and adds GitHub Pages demo support with HashRouter configuration.
Changes:
- Renamed messaging and UI labels from work time focus to absence/leave focus throughout the application
- Updated CSS class prefixes from
navds-toaksel-to align with design system updates - Added GitHub Pages demo deployment capability with HashRouter and demo-specific build configuration
Reviewed changes
Copilot reviewed 56 out of 58 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Added npm-run-all dependency |
| packages/sif-common-ui/src/inputs/duration-weekdays-input/* | Added custom week header support and month display in date labels |
| packages/sif-common-soknad-ds/src/setup/SoknadApplication.tsx | Added HashRouter option for GitHub Pages support |
| packages/sif-common-formik-ds/src/components/formik-time-input/TimeInput.tsx | Updated CSS classes from navds- to aksel- |
| packages/sif-common-core-ds/src/components/sif-guide-panel/sifGuidePanel.scss | Updated CSS classes from navds- to aksel- |
| apps/pleiepenger-sykt-barn/src/app/app.css | Updated CSS classes from navds- to aksel- |
| apps/opplaringspenger-soknad/vite.*.config.ts | Added IS_GITHUB_PAGES build configuration |
| apps/opplaringspenger-soknad/src/app/types/* | Simplified Kursdag type, added Features placeholder |
| apps/opplaringspenger-soknad/src/app/i18n/appMessages.ts | Renamed arbeidstidMessages to fraværMessages |
| apps/opplaringspenger-soknad/src/app/constants/MELLOMLAGRING_VERSJON.ts | Bumped version to 1.0.0 |
| apps/opplaringspenger-soknad/src/app/components/demo/DemoInfo.tsx | Added demo mode indicator component |
| apps/opplaringspenger-soknad/src/app/components/dager-med-tid-liste/DagerMedTidListe.tsx | Added handling for zero duration display |
| apps/opplaringspenger-soknad/src/app/App.tsx | Integrated demo mode with HashRouter |
| apps/opplaringspenger-soknad/playwright/* | Updated test expectations for new company name and terminology |
| apps/opplaringspenger-soknad/package.json | Added demo build scripts |
| apps/opplaringspenger-soknad/nais/demo-gcp.json | Removed demo GCP configuration |
| apps/opplaringspenger-soknad/mock/* | Updated mock data with new company name |
| apps/opplaringspenger-soknad/demo/index.html | Added GitHub Pages demo HTML |
| apps/opplaringspenger-soknad/.gitignore | Updated ignored directories |
| .github/workflows/build-gh-pages.yml | Added opplaringspenger-soknad to GitHub Pages workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.