Refactor utbetalinger #1068
Merged
Refactor utbetalinger #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ingen vits i å bygge opp setninger fra delsetninger
* Henter inn metode fra utbetalingerUtils som bare ble brukt her * Endrer metoden så vi ikke må legge på årstall for hånd
* Bedre navn på argumentene * Destrukturering av props og inline av definisjon
.at(-1) kom i ES2022 og er penere.
Flytter ingress tilbake opp et hakkˆ
Samme funksjon var duplisert to steder dypt i kode, så jeg trakk ut til en egen funksjon
Wrapper dem i en describe, gir mer konvensjonelle navn, fjerner en duplisert test
* .replace er ikke nødvendig; DateTimeFormat legger punktum på ordinaltall * syntaksendringer (disse funksjonene kommer ikke til å leve lenge)
Fremdeles noen bugs her, så dette bør anses som en checkpoint commit
(cherry picked from commit e097f3b)
Forebygger logg-spam under test
Forenklementell inkrementering
…ctor/utbetalinger # Conflicts: # src/utbetalinger/filter/FilterProvider.tsx # src/utbetalinger/filter/lib/FilterContext.ts # src/utbetalinger/filter/lib/filterLogAnalytics.ts # src/utbetalinger/filter/lib/filterMatch.test.ts # src/utbetalinger/filter/lib/filterMatch.ts # src/utbetalinger/filter/lib/filterReducer.test.ts # src/utbetalinger/filter/lib/filterReducer.ts # src/utbetalinger/filter/lib/filterResponses.ts
# Conflicts: # src/pages/_app.tsx # src/utbetalinger/beta/utbetalinger.module.css
almyy
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Omfattende refaktor og forenkling av src/utbetalinger