Journalstatus - håndter journalført og feilregistrert status, men ignorer disse #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test på flere journalstatuser
b162214
approved these changes
Jan 23, 2025
| ) { | ||
| if (statusSkalIgnoreres(inntektsmelding.journalStatus)) { | ||
| logger.info( | ||
| "Behandler ikke inntektsmelding {} da den har status: {}", |
There was a problem hiding this comment.
Kanskje logge journalpostId ikke inntektsmelding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vi får i dag en del støy i logger fordi det kommer inn inntektsmeldinger som er manuelt journalført eller feilregistrert, og disse enumene er ikke i vår kode. Disse feilene blir forsøkt rekjørt 10 ganger, alltid med samme resultat.
Jeg vil tro at det er trygt å håndtere disse og ignorere / ikke gjøre noe, da de allerede er manuelt håndtert - og koden vår tryner uansett nå, så ser ikke for meg at det kan bli så mye verre at vi logger og går videre med en gang.
En konsekvens med denne endringen er at vi kommer ikke lenger til å opprette en fordelingsoppgave for disse tilfellene, men det virker ikke som at det skal være nødvendig uansett, slik jeg forstår det i denne tråden:
https://nav-it.slack.com/archives/C6W9E5GPJ/p1737538097738059